Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use weak reference to hold bean objects so that they could be garbage collected #1676

Merged
merged 1 commit into from
Nov 17, 2018

Conversation

nobodyiam
Copy link
Member

Fixes #1670.

@codecov-io
Copy link

codecov-io commented Nov 17, 2018

Codecov Report

Merging #1676 into master will increase coverage by 0.02%.
The diff coverage is 64.7%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master   #1676      +/-   ##
===========================================
+ Coverage     48.77%   48.8%   +0.02%     
- Complexity     1906    1911       +5     
===========================================
  Files           392     392              
  Lines         11492   11524      +32     
  Branches       1196    1204       +8     
===========================================
+ Hits           5605    5624      +19     
- Misses         5458    5464       +6     
- Partials        429     436       +7
Impacted Files Coverage Δ Complexity Δ
.../framework/apollo/spring/property/SpringValue.java 87.71% <41.66%> (-12.29%) 20 <5> (+1)
...rk/apollo/spring/property/SpringValueRegistry.java 83.33% <77.27%> (-9.53%) 10 <4> (+5)
.../apollo/internals/RemoteConfigLongPollService.java 77.3% <0%> (-0.62%) 27% <0%> (-1%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d93a6ba...790ee89. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.08%) to 52.586% when pulling 790ee89 on nobodyiam:fix-1670 into d93a6ba on ctripcorp:master.

@nobodyiam nobodyiam merged commit c121a9e into apolloconfig:master Nov 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

apollo SpringValueRegistry不释放引用触发full gc
4 participants