Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block delete default cluster #1586

Merged
merged 2 commits into from
Oct 21, 2018
Merged

Block delete default cluster #1586

merged 2 commits into from
Oct 21, 2018

Conversation

zouyx
Copy link
Member

@zouyx zouyx commented Oct 19, 2018

修复

@codecov-io
Copy link

codecov-io commented Oct 19, 2018

Codecov Report

Merging #1586 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1586      +/-   ##
============================================
+ Coverage     48.62%   48.66%   +0.03%     
- Complexity     1899     1901       +2     
============================================
  Files           393      393              
  Lines         11494    11496       +2     
  Branches       1194     1195       +1     
============================================
+ Hits           5589     5594       +5     
+ Misses         5477     5473       -4     
- Partials        428      429       +1
Impacted Files Coverage Δ Complexity Δ
...llo/adminservice/controller/ClusterController.java 30.76% <100%> (+18.26%) 4 <0> (+2) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2dbb811...ee136b7. Read the comment docs.

@coveralls
Copy link

coveralls commented Oct 19, 2018

Coverage Status

Coverage increased (+0.04%) to 52.392% when pulling ee136b7 on zouyx:master into 2dbb811 on ctripcorp:master.

@nobodyiam
Copy link
Member

Thanks, will take a look soon.

Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@nobodyiam nobodyiam merged commit a8a4a0d into apolloconfig:master Oct 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants