Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: add gray operation on Open API #1518

Merged
merged 1 commit into from
Sep 29, 2018

Conversation

jieqian
Copy link

@jieqian jieqian commented Sep 27, 2018

gray release
gray deletion release
branch merge release
fetch gray release rules
update gray release rules
find branch
create branch
delete branch

@codecov-io
Copy link

codecov-io commented Sep 27, 2018

Codecov Report

Merging #1518 into master will increase coverage by 10.1%.
The diff coverage is 3.33%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1518      +/-   ##
============================================
+ Coverage     38.55%   48.65%   +10.1%     
- Complexity      151     1882    +1731     
============================================
  Files            41      394     +353     
  Lines          1092    11419   +10327     
  Branches        138     1172    +1034     
============================================
+ Hits            421     5556    +5135     
- Misses          616     5438    +4822     
- Partials         55      425     +370
Impacted Files Coverage Δ Complexity Δ
...ramework/apollo/portal/service/ReleaseService.java 2.38% <0%> (ø) 2 <0> (?)
...ramework/apollo/openapi/util/OpenApiBeanUtils.java 0% <0%> (ø) 0 <0> (?)
...apollo/openapi/dto/OpenGrayReleaseRuleItemDTO.java 0% <0%> (ø) 0 <0> (?)
...pollo/openapi/v1/controller/ReleaseController.java 2.04% <0%> (ø) 1 <0> (?)
...apollo/openapi/dto/NamespaceGrayDelReleaseDTO.java 0% <0%> (ø) 0 <0> (?)
...llo/adminservice/controller/ReleaseController.java 17.3% <0%> (ø) 3 <0> (?)
...p/framework/apollo/portal/api/AdminServiceAPI.java 13.15% <0%> (ø) 1 <0> (?)
.../apollo/portal/service/NamespaceBranchService.java 2.12% <0%> (ø) 1 <0> (?)
...ork/apollo/openapi/dto/OpenGrayReleaseRuleDTO.java 0% <0%> (ø) 0 <0> (?)
...tal/entity/model/NamespaceGrayDelReleaseModel.java 0% <0%> (ø) 0 <0> (?)
... and 355 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d66ee6...59e0850. Read the comment docs.

@coveralls
Copy link

coveralls commented Sep 27, 2018

Coverage Status

Coverage decreased (-0.7%) to 52.43% when pulling 2dba143f8dcfe20694156669a526895cc96a2750 on jieqian:gray_release_4_openapi into e0ba75c on ctripcorp:master.

2nd PR -> bugfix: fix and reformat for the code review
@jieqian jieqian force-pushed the gray_release_4_openapi branch from 25be97e to 59e0850 Compare September 29, 2018 04:03
Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants