Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support rolling clean up log file,based size and time policy. #1494

Merged
merged 1 commit into from
Sep 18, 2018
Merged

support rolling clean up log file,based size and time policy. #1494

merged 1 commit into from
Sep 18, 2018

Conversation

JaredTan95
Copy link
Member

No description provided.

@JaredTan95 JaredTan95 mentioned this pull request Sep 18, 2018
Closed
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.08%) to 52.118% when pulling 8629508 on JaredTan95:master into bafd02c on ctripcorp:master.

nobodyiam
nobodyiam approved these changes Sep 18, 2018
View reviewed changes
Copy link
Member

@nobodyiam nobodyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nobodyiam nobodyiam merged commit 615e25c into apolloconfig:master Sep 18, 2018
@nobodyiam
Copy link
Member

I upgraded apollo's spring boot to 2.0 recently, so that we could use spring boot's built-in feature (logging.file.max-size and logging.file.max-history) to do the job instead, see #1530

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nobodyiam nobodyiam nobodyiam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JaredTan95 @coveralls @nobodyiam