Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow public namespaces created with no org prefix #1476

Conversation

nobodyiam
Copy link
Member

Purpose

To allow the user create public namespaces with no org prefix

Brief changes

  1. Added a append org prefix checkbox in the namespace creation page
  2. Will check public namespace name global uniqueness before creation
    • global uniqueness means the name is not used as any public namespace as well as any private namespace

Effect

1. when append org prefix checkbox is checked (default behavior)

image

2. when append org prefix checkbox is unchecked

image

@codecov-io
Copy link

codecov-io commented Sep 12, 2018

Codecov Report

Merging #1476 into master will increase coverage by 0.12%.
The diff coverage is 85%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1476      +/-   ##
============================================
+ Coverage      48.4%   48.53%   +0.12%     
- Complexity     1801     1809       +8     
============================================
  Files           379      379              
  Lines         10930    10947      +17     
  Branches       1121     1125       +4     
============================================
+ Hits           5291     5313      +22     
+ Misses         5253     5245       -8     
- Partials        386      389       +3
Impacted Files Coverage Δ Complexity Δ
.../apollo/portal/controller/NamespaceController.java 3.77% <0%> (ø) 2 <0> (ø) ⬇️
...ork/apollo/portal/service/AppNamespaceService.java 71.42% <89.47%> (+4.76%) 19 <5> (+7) ⬆️
...lo/configservice/util/InstanceConfigAuditUtil.java 70.17% <0%> (-0.88%) 13% <0%> (-1%)
...ervice/service/ReleaseMessageServiceWithCache.java 86.9% <0%> (ø) 25% <0%> (ø) ⬇️
...work/apollo/biz/message/DatabaseMessageSender.java 66.66% <0%> (+16.66%) 8% <0%> (+2%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 976b69d...04f99dd. Read the comment docs.

@coveralls
Copy link

coveralls commented Sep 12, 2018

Coverage Status

Coverage increased (+0.07%) to 52.2% when pulling b949afa on nobodyiam:allow-public-namespace-with-no-org-prefix into 9e3aec5 on ctripcorp:master.

@nobodyiam nobodyiam force-pushed the allow-public-namespace-with-no-org-prefix branch from 04f99dd to 91ef9f7 Compare September 13, 2018 14:21
@nobodyiam nobodyiam force-pushed the allow-public-namespace-with-no-org-prefix branch from 91ef9f7 to b949afa Compare September 16, 2018 03:03
@nobodyiam nobodyiam merged commit adb4634 into apolloconfig:master Sep 16, 2018
@chickenlj
Copy link

Awesome, I think this can make the config model more flexible. Sometimes, people may need global namespace.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants