Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add removeChangeListener api #1462

Merged
merged 1 commit into from
Sep 9, 2018

Conversation

nobodyiam
Copy link
Member

No description provided.

@codecov-io
Copy link

codecov-io commented Sep 9, 2018

Codecov Report

Merging #1462 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1462      +/-   ##
============================================
+ Coverage     48.37%   48.39%   +0.02%     
  Complexity     1798     1798              
============================================
  Files           379      379              
  Lines         10928    10930       +2     
  Branches       1121     1121              
============================================
+ Hits           5286     5290       +4     
+ Misses         5254     5250       -4     
- Partials        388      390       +2
Impacted Files Coverage Δ Complexity Δ
...rip/framework/apollo/internals/AbstractConfig.java 81.01% <100%> (+0.16%) 49 <1> (+1) ⬆️
...ervice/service/ReleaseMessageServiceWithCache.java 85.71% <0%> (-1.2%) 24% <0%> (-1%)
...work/apollo/biz/message/DatabaseMessageSender.java 56.25% <0%> (+6.25%) 6% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee4cfcc...3f42821. Read the comment docs.

@coveralls
Copy link

coveralls commented Sep 9, 2018

Coverage Status

Coverage increased (+0.05%) to 51.967% when pulling 3f42821 on nobodyiam:remove-change-listener into ee4cfcc on ctripcorp:master.

@nobodyiam nobodyiam force-pushed the remove-change-listener branch from a18ff9d to 3f42821 Compare September 9, 2018 13:47
@nobodyiam nobodyiam merged commit 976b69d into apolloconfig:master Sep 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants