Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support multiple spring contexts #1436

Merged
merged 1 commit into from
Sep 3, 2018

Conversation

nobodyiam
Copy link
Member

No description provided.

@codecov-io
Copy link

codecov-io commented Sep 3, 2018

Codecov Report

Merging #1436 into master will decrease coverage by <.01%.
The diff coverage is 87.5%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1436      +/-   ##
============================================
- Coverage     48.45%   48.45%   -0.01%     
- Complexity     1798     1800       +2     
============================================
  Files           379      379              
  Lines         10923    10928       +5     
  Branches       1116     1121       +5     
============================================
+ Hits           5293     5295       +2     
  Misses         5244     5244              
- Partials        386      389       +3
Impacted Files Coverage Δ Complexity Δ
...ip/framework/apollo/mockserver/EmbeddedApollo.java 87.01% <ø> (-0.94%) 17 <0> (ø)
...apollo/spring/config/PropertySourcesProcessor.java 92% <100%> (+3.53%) 16 <5> (ø) ⬇️
...lo/spring/annotation/ApolloJsonValueProcessor.java 87.71% <100%> (ø) 10 <0> (ø) ⬇️
...pring/property/AutoUpdateConfigChangeListener.java 92.85% <100%> (+1.78%) 17 <0> (+1) ⬆️
...pring/property/SpringValueDefinitionProcessor.java 86.48% <72.72%> (-7.8%) 12 <8> (-1)
...apollo/spring/annotation/SpringValueProcessor.java 83.58% <87.5%> (-1.04%) 18 <3> (+1)
...rk/apollo/spring/property/SpringValueRegistry.java 92.85% <91.66%> (-7.15%) 5 <4> (+2)
...work/apollo/spring/property/PlaceholderHelper.java 81.53% <0%> (-3.08%) 24% <0%> (-2%)
.../apollo/internals/RemoteConfigLongPollService.java 77.91% <0%> (+0.61%) 28% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a926ea...ccc3afb. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 52.013% when pulling ccc3afb on nobodyiam:fix-multiple-contexts into 2a926ea on ctripcorp:master.

@nobodyiam nobodyiam merged commit cec2af3 into apolloconfig:master Sep 3, 2018
@nobodyiam nobodyiam deleted the fix-multiple-contexts branch July 15, 2023 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants