Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ldap support #1380

Merged
merged 2 commits into from
Aug 20, 2018
Merged

Add ldap support #1380

merged 2 commits into from
Aug 20, 2018

Conversation

nobodyiam
Copy link
Member

No description provided.

@nobodyiam nobodyiam mentioned this pull request Aug 19, 2018
@codecov-io
Copy link

codecov-io commented Aug 19, 2018

Codecov Report

Merging #1380 into master will decrease coverage by 10.2%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             master    #1380       +/-   ##
=============================================
- Coverage     48.75%   38.55%   -10.21%     
+ Complexity     1783      151     -1632     
=============================================
  Files           375       41      -334     
  Lines         10702     1092     -9610     
  Branches       1107      138      -969     
=============================================
- Hits           5218      421     -4797     
+ Misses         5105      616     -4489     
+ Partials        379       55      -324
Impacted Files Coverage Δ Complexity Δ
...k/apollo/common/datasource/TitanEntityManager.java
.../ctrip/framework/apollo/util/http/HttpRequest.java
...p/framework/apollo/biz/service/ReleaseService.java
...p/framework/apollo/portal/service/ItemService.java
...mework/apollo/portal/service/NamespaceService.java
...p/framework/apollo/spring/util/SpringInjector.java
.../ctrip/framework/apollo/portal/entity/po/Role.java
...k/apollo/portal/service/ReleaseHistoryService.java
...apollo/spring/annotation/SpringValueProcessor.java
...mework/apollo/portal/entity/vo/EnvClusterInfo.java
... and 323 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ea7582...1da4544. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.5%) to 51.676% when pulling 9eb7045152056c98f4c8db7a62257995efb117db on nobodyiam:pandalin-ldap into ccacba2 on ctripcorp:master.

@pandalin
Copy link

@nobodyiam 本地测试了下,ldap模块没问题

@nobodyiam nobodyiam merged commit ccc3476 into apolloconfig:master Aug 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants