Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unify portal logout url to /user/logout #1363

Merged
merged 2 commits into from
Aug 13, 2018

Conversation

nobodyiam
Copy link
Member

No description provided.

@nobodyiam
Copy link
Member Author

Fix #1359 when users customized the authentication

@codecov-io
Copy link

codecov-io commented Aug 13, 2018

Codecov Report

Merging #1363 into master will increase coverage by 10.4%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1363      +/-   ##
============================================
+ Coverage     38.55%   48.96%   +10.4%     
- Complexity      151     1777    +1626     
============================================
  Files            41      372     +331     
  Lines          1092    10645    +9553     
  Branches        138     1105     +967     
============================================
+ Hits            421     5212    +4791     
- Misses          616     5052    +4436     
- Partials         55      381     +326
Impacted Files Coverage Δ Complexity Δ
...lo/portal/spi/configuration/AuthConfiguration.java 10.1% <0%> (ø) 1 <0> (?)
...trip/framework/apollo/openapi/entity/Consumer.java 45.83% <0%> (ø) 7% <0%> (?)
...rk/apollo/biz/eureka/ApolloEurekaClientConfig.java 25% <0%> (ø) 1% <0%> (?)
...mework/apollo/portal/component/PortalSettings.java 55% <0%> (ø) 5% <0%> (?)
.../framework/apollo/util/parser/ParserException.java 100% <0%> (ø) 2% <0%> (?)
.../framework/apollo/spring/property/SpringValue.java 100% <0%> (ø) 19% <0%> (?)
...ramework/apollo/openapi/dto/OpenEnvClusterDTO.java 0% <0%> (ø) 0% <0%> (?)
...work/apollo/biz/service/ReleaseHistoryService.java 91.66% <0%> (ø) 5% <0%> (?)
...mework/apollo/portal/entity/vo/EnvClusterInfo.java 0% <0%> (ø) 0% <0%> (?)
...inservice/controller/InstanceConfigController.java 92.4% <0%> (ø) 15% <0%> (?)
... and 322 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update faf7d3b...0196259. Read the comment docs.

@nobodyiam nobodyiam merged commit a4c65aa into apolloconfig:master Aug 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants