Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add delete app namespace api #1277

Merged
merged 1 commit into from
Jul 22, 2018

Conversation

nobodyiam
Copy link
Member

No description provided.

@codecov-io
Copy link

codecov-io commented Jul 22, 2018

Codecov Report

Merging #1277 into master will decrease coverage by 0.23%.
The diff coverage is 14.45%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1277      +/-   ##
============================================
- Coverage     49.17%   48.93%   -0.24%     
- Complexity     1727     1728       +1     
============================================
  Files           368      369       +1     
  Lines         10392    10451      +59     
  Branches       1063     1070       +7     
============================================
+ Hits           5110     5114       +4     
- Misses         4904     4959      +55     
  Partials        378      378
Impacted Files Coverage Δ Complexity Δ
...apollo/portal/listener/AppInfoChangedListener.java 15.38% <ø> (+7.38%) 2 <0> (ø) ⬇️
...ip/framework/apollo/portal/service/AppService.java 3.33% <ø> (ø) 2 <0> (ø) ⬇️
...rip/framework/apollo/biz/service/AdminService.java 94.73% <ø> (ø) 5 <0> (ø) ⬇️
...llo/portal/listener/AppNamespaceDeletionEvent.java 0% <0%> (ø) 0 <0> (?)
...p/framework/apollo/portal/api/AdminServiceAPI.java 14.38% <0%> (-0.22%) 1 <0> (ø)
.../spi/defaultimpl/DefaultRolePermissionService.java 71.81% <0%> (-7.19%) 24 <0> (ø)
...ork/apollo/portal/service/AppNamespaceService.java 64.91% <0%> (-12.18%) 12 <0> (ø)
...dminservice/controller/AppNamespaceController.java 35.29% <0%> (-14.71%) 2 <0> (ø)
.../apollo/portal/controller/NamespaceController.java 4.25% <0%> (-0.3%) 2 <0> (ø)
...mework/apollo/portal/service/NamespaceService.java 68.75% <0%> (ø) 25 <0> (ø) ⬇️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d23e60e...d1db52a. Read the comment docs.

@nobodyiam nobodyiam merged commit 0c4069f into apolloconfig:master Jul 22, 2018
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 52.55% when pulling d1db52a on nobodyiam:delete-appnamespace-api into d23e60e on ctripcorp:master.

@nobodyiam nobodyiam mentioned this pull request Jul 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants