Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

externalize application-github.properties and apollo-env.properties #1273

Conversation

nobodyiam
Copy link
Member

By externalizing application-github.properties and apollo-env.properties, we could upload apollo-configservice, apollo-adminservice and apollo-portal installation files with releases.

So our users don't need to package them locally anymore, instead they could simply download them from our releases, do some simple configuration, and start apollo services easily!

@codecov-io
Copy link

codecov-io commented Jul 21, 2018

Codecov Report

Merging #1273 into master will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1273      +/-   ##
============================================
- Coverage     49.01%   48.95%   -0.06%     
+ Complexity     1701     1698       -3     
============================================
  Files           366      366              
  Lines         10277    10277              
  Branches       1043     1043              
============================================
- Hits           5037     5031       -6     
- Misses         4868     4873       +5     
- Partials        372      373       +1
Impacted Files Coverage Δ Complexity Δ
...work/apollo/biz/message/DatabaseMessageSender.java 56.25% <0%> (-10.42%) 6% <0%> (-2%)
.../apollo/internals/RemoteConfigLongPollService.java 77.3% <0%> (-0.62%) 27% <0%> (-1%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16bf9e9...da1ccae. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.05%) to 52.583% when pulling da1ccae on nobodyiam:externalize-meta-service-and-db-properties-file into 16bf9e9 on ctripcorp:master.

@nobodyiam nobodyiam merged commit 87c65bf into apolloconfig:master Jul 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants