Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

when server returns status code other than 200 and 304, we should throw ApolloConfigStatusCodeException #1212

Merged
merged 1 commit into from
Jun 30, 2018

Conversation

nobodyiam
Copy link
Member

No description provided.

@codecov-io
Copy link

codecov-io commented Jun 30, 2018

Codecov Report

Merging #1212 into master will increase coverage by 0.08%.
The diff coverage is 75%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1212      +/-   ##
============================================
+ Coverage     48.67%   48.75%   +0.08%     
- Complexity     1682     1686       +4     
============================================
  Files           365      365              
  Lines         10174    10181       +7     
  Branches       1030     1031       +1     
============================================
+ Hits           4952     4964      +12     
+ Misses         4860     4854       -6     
- Partials        362      363       +1
Impacted Files Coverage Δ Complexity Δ
...lo/exceptions/ApolloConfigStatusCodeException.java 57.14% <100%> (+57.14%) 2 <1> (+2) ⬆️
...com/ctrip/framework/apollo/util/http/HttpUtil.java 76.36% <60%> (-2.07%) 7 <0> (ø)
...lo/configservice/util/InstanceConfigAuditUtil.java 70.17% <0%> (-5.27%) 13% <0%> (-2%)
...ervice/service/ReleaseMessageServiceWithCache.java 86.9% <0%> (+1.19%) 25% <0%> (+1%) ⬆️
...ework/apollo/internals/RemoteConfigRepository.java 87.82% <0%> (+3.84%) 22% <0%> (+1%) ⬆️
...work/apollo/biz/message/DatabaseMessageSender.java 66.66% <0%> (+10.41%) 8% <0%> (+2%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d5646f...1f5e188. Read the comment docs.

@nobodyiam nobodyiam merged commit 0872057 into apolloconfig:master Jun 30, 2018
@coveralls
Copy link

Coverage Status

Coverage increased (+0.09%) to 52.323% when pulling 1f5e188 on nobodyiam:fix-404-exception into 9d5646f on ctripcorp:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants