Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the issue brought by 0.10.0 that Spring related classes are mistakenly loaded via DefaultInjector #1019

Merged
merged 2 commits into from
Mar 27, 2018

Conversation

nobodyiam
Copy link
Member

which causes exceptions when there is no Spring libraries available.

…kenly loaded via DefaultInjector, which causes exceptions when there is no Spring libraries available.
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.09%) to 52.164% when pulling 3990dc3 on nobodyiam:0.10.1 into 37b6485 on ctripcorp:master.

@codecov-io
Copy link

codecov-io commented Mar 27, 2018

Codecov Report

Merging #1019 into master will decrease coverage by 0.08%.
The diff coverage is 69.69%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1019      +/-   ##
============================================
- Coverage     48.67%   48.59%   -0.09%     
- Complexity     1674     1676       +2     
============================================
  Files           364      365       +1     
  Lines         10146    10166      +20     
  Branches       1027     1028       +1     
============================================
+ Hits           4939     4940       +1     
- Misses         4844     4863      +19     
  Partials        363      363
Impacted Files Coverage Δ Complexity Δ
...ip/framework/apollo/internals/DefaultInjector.java 66.66% <ø> (-3.71%) 3 <0> (ø)
...apollo/spring/annotation/SpringValueProcessor.java 84.61% <100%> (ø) 17 <0> (ø) ⬇️
...apollo/spring/config/PropertySourcesProcessor.java 95.34% <100%> (ø) 15 <0> (ø) ⬇️
...ring/boot/ApolloApplicationContextInitializer.java 91.3% <100%> (ø) 5 <0> (ø) ⬇️
...m/ctrip/framework/apollo/build/ApolloInjector.java 40.9% <100%> (ø) 5 <1> (ø) ⬇️
...lo/spring/annotation/ApolloJsonValueProcessor.java 87.71% <100%> (ø) 10 <0> (ø) ⬇️
...pring/property/AutoUpdateConfigChangeListener.java 91.07% <100%> (ø) 16 <0> (ø) ⬇️
...pring/property/SpringValueDefinitionProcessor.java 94.28% <100%> (ø) 13 <0> (ø) ⬇️
...p/framework/apollo/spring/util/SpringInjector.java 56.52% <56.52%> (ø) 4 <4> (?)
...work/apollo/biz/message/DatabaseMessageSender.java 56.25% <0%> (-10.42%) 6% <0%> (-2%)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37b6485...3990dc3. Read the comment docs.

@nobodyiam nobodyiam merged commit 6b2467d into apolloconfig:master Mar 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants