Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support incremental configuration synchronization client #90
feat: support incremental configuration synchronization client #90
Changes from 1 commit
f654cb3
44b70fa
6859fe1
9842289
b454698
89321ac
08e2705
69f4677
121317b
d489886
4e9e146
545c074
07b3b13
be92b58
201b782
eb737cf
18e2139
81661cf
7d1ffd7
a5a47e4
66aae85
8cf6c6d
0f7d2a3
ee7e05a
d3abb56
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to the fromString logic, configSyncType cannot be null, and we can use
==
to compare enums.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is the method public? Would package-private be a better choice?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix test method name and remove unused setup.
The method name suggests testing with null previous configurations, but it actually tests with null changes. Also, there are unused variables in the setup.
📝 Committable suggestion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix test method name and simplify test setup.
The method name suggests testing with null changes, but it actually tests with null previous configurations. Also, the test setup can be simplified.
📝 Committable suggestion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Reduce code duplication in helper methods.
Consider refactoring to reduce duplication between
assembleApolloConfig
andassembleApolloConfigWithIncrementalSync
methods.📝 Committable suggestion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add parameter validation in constructor.
The constructor should validate its parameters to prevent invalid states:
📝 Committable suggestion