Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix beanName2SpringValueDefinitions cache issue #16

Merged
merged 1 commit into from
Jan 21, 2023
Merged

Conversation

nobodyiam
Copy link
Member

What's the purpose of this PR

Fix beanName2SpringValueDefinitions cache issue

Which issue(s) this PR fixes:

Fixes #13

Brief changelog

  • use computeIfAbsent method

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Read the Contributing Guide before making this pull request.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit tests to verify the code.
  • Run mvn clean test to make sure this pull request doesn't break anything.
  • Update the CHANGES log.

@codecov
Copy link

codecov bot commented Jan 18, 2023

Codecov Report

Merging #16 (10fe975) into main (af2751f) will increase coverage by 0.01%.
The diff coverage is 50.00%.

@@             Coverage Diff              @@
##               main      #16      +/-   ##
============================================
+ Coverage     68.22%   68.24%   +0.01%     
  Complexity     1177     1177              
============================================
  Files           165      165              
  Lines          5124     5123       -1     
  Branches        561      560       -1     
============================================
  Hits           3496     3496              
  Misses         1365     1365              
+ Partials        263      262       -1     
Impacted Files Coverage Δ
...pring/property/SpringValueDefinitionProcessor.java 88.88% <50.00%> (+2.40%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@nobodyiam nobodyiam merged commit 8d17de5 into main Jan 21, 2023
@nobodyiam nobodyiam deleted the fix-cache-bug branch January 21, 2023 00:58
@github-actions github-actions bot locked and limited conversation to collaborators Jan 21, 2023
@nobodyiam nobodyiam added this to the 2.1.0 milestone Jan 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

缓存问题
2 participants