Skip to content

Commit

Permalink
fix ut
Browse files Browse the repository at this point in the history
  • Loading branch information
@dyx1234
dyx1234 committed Oct 27, 2024
1 parent 2f5ddf6 commit f95ca86
Show file tree
Hide file tree
Showing 2 changed files with 113 additions and 226 deletions.
4 changes: 4 additions & 0 deletions ...ient/src/main/java/com/ctrip/framework/apollo/internals/K8sConfigMapConfigRepository.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,10 @@ public K8sConfigMapConfigRepository(String namespace, ConfigRepository upstream)
this.setUpstreamRepository(upstream);
}

String getConfigMapKey() {
return configMapKey;
}

String getConfigMapName() {
return configMapName;
}
Expand Down
335 changes: 109 additions & 226 deletions .../src/test/java/com/ctrip/framework/apollo/internals/K8sConfigMapConfigRepositoryTest.java
View file
Original file line number Diff line number Diff line change
@@ -1,278 +1,161 @@
/*
* Copyright 2022 Apollo Authors
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*
*/
package com.ctrip.framework.apollo.internals;

import com.ctrip.framework.apollo.kubernetes.KubernetesManager;
import com.ctrip.framework.apollo.build.MockInjector;
import com.ctrip.framework.apollo.enums.ConfigSourceType;
import com.ctrip.framework.apollo.exceptions.ApolloConfigException;
import com.ctrip.framework.apollo.kubernetes.KubernetesManager;
import com.ctrip.framework.apollo.util.ConfigUtil;
import com.ctrip.framework.apollo.util.factory.PropertiesFactory;
import io.kubernetes.client.openapi.apis.CoreV1Api;
import io.kubernetes.client.openapi.models.V1ConfigMap;
import io.kubernetes.client.openapi.models.V1ObjectMeta;
import org.junit.After;
import org.junit.Before;
import org.junit.Test;
import org.junit.jupiter.api.BeforeEach;
import org.mockito.InjectMocks;
import org.mockito.Mock;
import org.mockito.invocation.InvocationOnMock;
import org.mockito.stubbing.Answer;

import java.util.HashMap;
import java.util.Map;
import java.util.Properties;

import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertNotNull;
import static org.mockito.ArgumentMatchers.anyString;
import static org.mockito.Mockito.*;

public class K8sConfigMapConfigRepositoryTest {
private static String someAppId = "someApp";
private static String someCluster = "someCluster";
private String someNamespace = "default";
private ConfigRepository upstreamRepo;
private Properties someProperties;
private static final String someAppId = "someApp";
private static final String someConfigmapName = "apollo-configcache-someApp";
private static final String someCluster = "someCluster";

private static final String defaultKey = "defaultKey";
private static final String defaultValue = "defaultValue";
private ConfigSourceType someSourceType;
private V1ConfigMap configMap;
private CoreV1Api coreV1Api;
private static final String defaultJsonValue = "{\"id\":123,\"name\":\"John Doe\",\"email\":\"[email protected]\"}";

@InjectMocks
private ConfigRepository upstreamRepo;
private Properties someProperties;
private ConfigSourceType someSourceType = ConfigSourceType.LOCAL;
private V1ConfigMap configMap;
private Map<String, String> data;
private KubernetesManager kubernetesManager;
@Mock
private ConfigUtil configUtil;
private K8sConfigMapConfigRepository configmapRepo;
private K8sConfigMapConfigRepository k8sConfigMapConfigRepository;


@Before
public void setUp() {
// mock configUtil
MockInjector.setInstance(ConfigUtil.class, new MockConfigUtil());
// mock kubernetesManager
kubernetesManager = mock(KubernetesManager.class);
MockInjector.setInstance(KubernetesManager.class, kubernetesManager);

// mock upstream
someProperties = new Properties();
someProperties.setProperty(defaultKey, defaultValue);
upstreamRepo = mock(ConfigRepository.class);
when(upstreamRepo.getConfig()).thenReturn(someProperties);
when(upstreamRepo.getSourceType()).thenReturn(someSourceType);

Map<String, String> data = new HashMap<>();
data.put(defaultKey, defaultValue);
// make comfigmap
data = new HashMap<>();
data.put(defaultKey, defaultJsonValue);
configMap = new V1ConfigMap()
.metadata(new V1ObjectMeta().name(someAppId).namespace(someNamespace))
.data(data);

someSourceType = ConfigSourceType.LOCAL;
upstreamRepo = mock(ConfigRepository.class);
when(upstreamRepo.getConfig()).thenReturn(someProperties);
when(upstreamRepo.getSourceType()).thenReturn(someSourceType);

// mock ConfigUtil
configUtil = mock(ConfigUtil.class);
when(configUtil.getAppId()).thenReturn("testAppId");
when(configUtil.getCluster()).thenReturn("default");
when(configUtil.getK8sNamespace()).thenReturn("default");
when(configUtil.isPropertyKubernetesCacheEnabled()).thenReturn(true);
when(configUtil.isOverrideSystemProperties()).thenReturn(false);
when(configUtil.getDefaultLocalCacheDir()).thenReturn("/cache");
when(configUtil.getMetaServerDomainName()).thenReturn("http://meta.server");
k8sConfigMapConfigRepository = new K8sConfigMapConfigRepository(someNamespace, upstreamRepo);

coreV1Api = mock(CoreV1Api.class);
MockInjector.setInstance(ConfigUtil.class, configUtil);
MockInjector.setInstance(CoreV1Api.class, coreV1Api);
}

kubernetesManager = new KubernetesManager(coreV1Api);
MockInjector.setInstance(KubernetesManager.class, kubernetesManager);

//configmapRepo = new K8sConfigMapConfigRepository(someNamespace, kubernetesManager);
MockInjector.setInstance(K8sConfigMapConfigRepository.class, configmapRepo);
@Test
public void testSetConfigMapKey() {
when(kubernetesManager.createConfigMap(anyString(), anyString(), any())).thenReturn("someAppId");
k8sConfigMapConfigRepository.setConfigMapKey(someCluster, someNamespace);
assertEquals(someCluster +"-"+ someNamespace, k8sConfigMapConfigRepository.getConfigMapKey());
}

PropertiesFactory propertiesFactory = mock(PropertiesFactory.class);
when(propertiesFactory.getPropertiesInstance()).thenReturn(new Properties());
MockInjector.setInstance(PropertiesFactory.class, propertiesFactory);
@Test
public void testSetConfigMapName() {
k8sConfigMapConfigRepository.setConfigMapName(someAppId, false);
assertEquals(someConfigmapName, k8sConfigMapConfigRepository.getConfigMapName());
}

@After
public void tearDown() throws Exception {
MockInjector.reset();
/**
* 测试sync方法成功从上游数据源同步
*/
@Test
public void testSyncSuccessFromUpstream() throws Throwable {
// arrange
k8sConfigMapConfigRepository.setUpstreamRepository(upstreamRepo);

// act
k8sConfigMapConfigRepository.sync();

// assert
verify(upstreamRepo, times(1)).getConfig();
}

// @Test
// public void testSetConfigMapKey() {
// when(kubernetesManager.createConfigMap(anyString(), anyString(), any())).thenReturn("someAppId");
// configmapRepo.setConfigMapKey(someCluster, someNamespace);
// assertEquals(someCluster +"-"+ someNamespace, configmapRepo.getConfigMapKey());
// }
//

@Test(expected = Exception.class)
public void testSetConfigMapNameWithNullAppId() {
configmapRepo.setConfigMapName(null, false);
/**
* 测试sync方法从上游数据源同步失败，成功从Kubernetes的ConfigMap中加载
*/
@Test
public void testSyncFailFromUpstreamSuccessFromConfigMap() throws Throwable {
// arrange
ConfigRepository upstream = mock(ConfigRepository.class);
when(upstream.getConfig()).thenThrow(new RuntimeException("Upstream sync failed"));
k8sConfigMapConfigRepository.setUpstreamRepository(upstream);
when(kubernetesManager.getValueFromConfigMap(anyString(), anyString(), anyString())).thenReturn(data.get(defaultKey));

// act
k8sConfigMapConfigRepository.sync();

// assert
verify(kubernetesManager, times(1)).getValueFromConfigMap(anyString(), anyString(), anyString());
}

@Test
public void testSetConfigMapName() {
configmapRepo.setConfigMapName(someAppId, false);
assertEquals(someConfigmapName, configmapRepo.getConfigMapName());
public void testGetConfig() {
// Arrange
Properties expectedProperties = new Properties();
expectedProperties.setProperty(defaultKey, defaultValue);
when(upstreamRepo.getConfig()).thenReturn(expectedProperties);
// Act
Properties actualProperties = k8sConfigMapConfigRepository.getConfig();
// Assert
assertNotNull(actualProperties);
assertEquals(defaultValue, actualProperties.getProperty(defaultKey));
}

@Test
public void testPersistConfigMap() {
// Arrange
Properties properties = new Properties();
properties.setProperty(defaultKey, defaultValue);
// Act
k8sConfigMapConfigRepository.persistConfigMap(properties);
// Assert
verify(kubernetesManager, times(1)).updateConfigMap(anyString(), anyString(), anyMap());
}

@Test
public void testOnRepositoryChange() {
// Arrange
Properties newProperties = new Properties();
newProperties.setProperty(defaultKey, defaultValue);
// Act
k8sConfigMapConfigRepository.onRepositoryChange(someNamespace, newProperties);
// Assert
verify(kubernetesManager, times(1)).updateConfigMap(anyString(), anyString(), anyMap());
}

// @Test
// public void testOnRepositoryChange() throws Exception {
// RepositoryChangeListener someListener = mock(RepositoryChangeListener.class);
//
// // 创建一个 LocalFileConfigRepository 实例，作为上游仓库
// LocalFileConfigRepository upstreamRepo = mock(LocalFileConfigRepository.class);
// when(upstreamRepo.getSourceType()).thenReturn(ConfigSourceType.LOCAL);
//
// // 创建一个模拟的 KubernetesManager
// KubernetesManager mockKubernetesManager = mock(KubernetesManager.class);
// when(mockKubernetesManager.checkConfigMapExist(anyString(), anyString())).thenReturn(true);
// doNothing().when(mockKubernetesManager).createConfigMap(anyString(), anyString(), any());
//
// K8sConfigMapConfigRepository k8sConfigMapConfigRepository = new K8sConfigMapConfigRepository("someNamespace", upstreamRepo);
// k8sConfigMapConfigRepository.initialize();
//
// // 设置本地缓存目录并添加监听器
// k8sConfigMapConfigRepository.addChangeListener(someListener);
// k8sConfigMapConfigRepository.getConfig();
//
// Properties anotherProperties = new Properties();
// anotherProperties.put("anotherKey", "anotherValue");
//
// ConfigSourceType anotherSourceType = ConfigSourceType.LOCAL;
// when(upstreamRepo.getSourceType()).thenReturn(anotherSourceType);
//
// // 调用 onRepositoryChange 方法，模拟仓库配置发生变化
// k8sConfigMapConfigRepository.onRepositoryChange("someNamespace", anotherProperties);
//
// // 使用 ArgumentCaptor 捕获监听器的调用参数
// final ArgumentCaptor<Properties> captor = ArgumentCaptor.forClass(Properties.class);
// verify(someListener, times(1)).onRepositoryChange(eq("someNamespace"), captor.capture());
//
// // 断言捕获的配置与 anotherProperties 相同
// assertEquals(anotherProperties, captor.getValue());
// // 断言 K8sConfigMapConfigRepository 的源类型更新为 anotherSourceType
// assertEquals(anotherSourceType, k8sConfigMapConfigRepository.getSourceType());
// }
public static class MockConfigUtil extends ConfigUtil {
@Override
public String getAppId() {
return someAppId;
}

/**
* 测试persistConfigMap方法成功持久化配置信息
*/
// @Test
// public void testPersistConfigMap() {
// K8sConfigMapConfigRepository repo = new K8sConfigMapConfigRepository(someNamespace);
// doNothing().when(kubernetesManager).updateConfigMap(anyString(), anyString(), anyMap());
// repo.persistConfigMap(someProperties);
// verify(kubernetesManager, times(1)).updateConfigMap(anyString(), anyString(), anyMap());
// }
@Override
public String getCluster() {
return someCluster;
}
}

// /**
// * 测试sync方法成功从上游数据源同步
// */
// @Test
// public void testSyncSuccessFromUpstream() throws Throwable {
// K8sConfigMapConfigRepository repo = new K8sConfigMapConfigRepository(someNamespace);
//
// // arrange
// ConfigRepository upstream = mock(ConfigRepository.class);
// Properties upstreamProperties = new Properties();
// upstreamProperties.setProperty("key", "value");
// when(upstream.getConfig()).thenReturn(upstreamProperties);
// when(upstream.getSourceType()).thenReturn(ConfigSourceType.REMOTE);
// repo.setUpstreamRepository(upstream);
//
//// // mock KubernetesManager
//// when(kubernetesManager.createConfigMap(anyString(), anyString(), anyMap()))
//// .thenReturn(true);
//// setField(repo, "kubernetesManager", kubernetesManager);
//
// // act
// repo.sync();
//
// // assert
// verify(upstream, times(1)).getConfig();
// }
//
// @Test
// public void testSyncFromUpstreamWithFileStorage() throws Exception {
// K8sConfigMapConfigRepository repo = new K8sConfigMapConfigRepository(someNamespace);
//
//
// Properties upstreamProperties = new Properties();
// upstreamProperties.setProperty("key1", "value1");
//
// when(upstreamRepo.getConfig()).thenReturn(upstreamProperties);
// when(upstreamRepo.getSourceType()).thenReturn(ConfigSourceType.LOCAL);
//
// repo.sync();
//
// Properties config = repo.getConfig();
// assertEquals("value1", config.getProperty("key1"));
// assertEquals(ConfigSourceType.LOCAL, repo.getSourceType());
// }
//
// @Test
// public void testSyncFromUpstreamWithRemote() throws Exception {
// K8sConfigMapConfigRepository repo = new K8sConfigMapConfigRepository(someNamespace);
//
// Properties upstreamProperties = new Properties();
// upstreamProperties.setProperty("key2", "value2");
//
// when(upstreamRepo.getConfig()).thenReturn(upstreamProperties);
// when(upstreamRepo.getSourceType()).thenReturn(ConfigSourceType.REMOTE);
//
// repo.sync();
//
// Properties config = repo.getConfig();
// assertEquals("value2", config.getProperty("key2"));
// assertEquals(ConfigSourceType.REMOTE, repo.getSourceType());
// }
//
// @Test
// public void testSyncFromK8s() throws Exception {
// K8sConfigMapConfigRepository repo = new K8sConfigMapConfigRepository(someNamespace);
//
// Properties k8sProperties = new Properties();
// k8sProperties.setProperty("key3", "value3");
//
// when(kubernetesManager.getValueFromConfigMap(anyString(), anyString(), anyString()))
// .thenReturn(Base64.getEncoder().encodeToString("{\"key3\":\"value3\"}".getBytes()));
//
// repo.sync();
//
// Properties config = repo.getConfig();
// assertEquals("value3", config.getProperty("key3"));
// assertEquals(ConfigSourceType.CONFIGMAP, repo.getSourceType());
// }
//
//
// /**
// * 测试sync方法从上游数据源同步失败，成功从Kubernetes的ConfigMap中加载
// */
// @Test
// public void testSyncFailFromUpstreamSuccessFromConfigMap() throws Throwable {
// K8sConfigMapConfigRepository repo = new K8sConfigMapConfigRepository(someNamespace);
// // arrange
// ConfigRepository upstream = mock(ConfigRepository.class);
// when(upstream.getConfig()).thenThrow(new RuntimeException("Upstream sync failed"));
// repo.setUpstreamRepository(upstream);
// when(kubernetesManager.getValueFromConfigMap(anyString(), anyString(), anyString())).thenReturn("encodedConfig");
//
// // act
// repo.sync();
//
// // assert
// verify(kubernetesManager, times(1)).getValueFromConfigMap(anyString(), anyString(), anyString());
// }
//
}

0 comments on commit f95ca86

Please sign in to comment.