Skip to content

Conversation

jsumners-nr
Copy link
Contributor

#28 (comment)

This PR allows clear code to be written in this project.

Copy link
Member

@timfish timfish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm against diverging from idiomatic Rust.

  • Anyone who's proficient in Rust will find this very strange and jarring, especially clippy::needless_return
  • If we stick to the clippy defaults we can skip endless debates driven by opinions and preferences
  • @bengl chose clippy::pedantic for a reason so I doubt this change would ever make it upstream

@jsumners-nr
Copy link
Contributor Author

Functions should be clear in their return statements.

@AbhiPrasad
Copy link
Member

I also agree, we should aim to stick with the clippy defaults as much as possible.

This also makes it easier for LLMs to navigate and reason through the codebase, which I think is important.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants