flight-fix #475
Open
flight-fix #475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ycaK
requested review from
benediktvaldez,
koddsson,
kristjanmik and
MiniGod
as code owners
Closed
|
Great work! We should try to extend the status response to the .plannedArrival and .realArrival fields to support legacy API calls. |
I've changed the real arrival data to output the same as now ('\r\n').
Changed planned arrival to output time from the status data. -> if there is no data it will be sent as unidentified
CircleCi didn't really like the change(as sometimes the data may be unidentified), so now the planned arrival return the same data as status.
|
I've made the planned arrival return the same data as the status |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to: #474
EDIT: Need to change to LF + some indentation
EDIT: All fixed and ready for deployment