Aircraft endpoint

[valentinoli]

Includes the implementation itself in ìndex.js` along with the documentation and integration-test files.

Haven't yet added documentation for the endpoint to the gh-pages branch.

[valentinoli]

Issue reference #430

[MiniGod]

You got a few lint errors. See the results on circle-ci:
https://circleci.com/gh/apis-is/apis/229

I think you should be able to fix it by running the following:
npm run lint -- --fix

Other than that, this looks good to me.

[MiniGod]

Great! But now the build has another error :( It's not very clear from the error why it is failing, but it looks like you're lacking mocks for the HTTP requests to samgongustofa.is. You can, for instance, look at how the horses endpoint has implemented the mocks: https://github.com/apis-is/apis/blob/1fb161a/endpoints/horses/tests/integration_test.js#L22-L41

Basically add multiple nock rules, as well as the fixture files (which is the HTML response from samgongustofa.is).

[valentinoli]

Thanks for the feedback. That's strange since I copied the structure for integration-test.js from the /ship endpoint which also scrapes data from samgongustofa.is, so I naively assumed that would be fine. I'm not familiar with nock, so I'm not sure if I quite understand what you mean, but I'll try to figure it out and follow your advice.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[MiniGod]

New PR: #480