Skip to content

build(package): update referred packages to latest version #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 4, 2023
Merged

build(package): update referred packages to latest version #40

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6e65e2c
build(package): update referred packages to latest version
hamzamahmood Mar 28, 2023
7209558
Microsoft.NET.Test.Sdk version updated to 17.5.0
hamzamahmood Mar 28, 2023
6f1fda7
TestHelper IsArrayOfJObject method refactored
hamzamahmood Mar 31, 2023
f3addfa
update System.Net.Http.Json to 7.0.1
hamzamahmood Apr 3, 2023
1b75244
reverting Newtonsoft.Json version from 13.0.3 to 13.0.2
hamzamahmood Apr 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions APIMatic.Core.Test/APIMatic.Core.Test.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,17 +7,17 @@
</PropertyGroup>

<ItemGroup>
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="16.9.4" />
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.5.0" />
<PackageReference Include="coverlet.msbuild" Version="3.2.0">
<PrivateAssets>all</PrivateAssets>
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
</PackageReference>
<PackageReference Include="SonarAnalyzer.CSharp" Version="8.48.0.56517">
<PackageReference Include="SonarAnalyzer.CSharp" Version="8.51.0.59060">
<PrivateAssets>all</PrivateAssets>
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
</PackageReference>
<PackageReference Include="NUnit" Version="3.13.3" />
<PackageReference Include="NUnit3TestAdapter" Version="4.2.1" />
<PackageReference Include="NUnit3TestAdapter" Version="4.3.1" />
<PackageReference Include="RichardSzalay.MockHttp" Version="6.0.0" />
<PackageReference Include="System.Net.Http.Json" Version="7.0.0" />
</ItemGroup>
Expand Down
10 changes: 5 additions & 5 deletions APIMatic.Core/APIMatic.Core.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,14 +30,14 @@

<ItemGroup>
<PackageReference Include="Microsoft.CSharp" Version="4.7.0" />
<PackageReference Include="Microsoft.Json.Pointer" Version="2.2.0" />
<PackageReference Include="Polly" Version="7.2.1" />
<PackageReference Include="SonarAnalyzer.CSharp" Version="8.48.0.56517">
<PackageReference Include="Microsoft.Json.Pointer" Version="2.3.0" />
<PackageReference Include="Polly" Version="7.2.3" />
<PackageReference Include="SonarAnalyzer.CSharp" Version="8.55.0.65544">
<PrivateAssets>all</PrivateAssets>
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
</PackageReference>
<PackageReference Include="System.Collections.Immutable" Version="1.5.0" />
<PackageReference Include="Newtonsoft.Json" Version="13.0.2" />
<PackageReference Include="System.Collections.Immutable" Version="7.0.0" />
<PackageReference Include="Newtonsoft.Json" Version="13.0.3" />
</ItemGroup>
<ItemGroup>
<InternalsVisibleTo Include="APIMatic.Core.Test" />
Expand Down
2 changes: 1 addition & 1 deletion APIMatic.Core/Types/VoidType.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,5 +6,5 @@ namespace APIMatic.Core.Types
/// <summary>
/// This represents the void ReturnType for API calls
/// </summary>
public class VoidType { }
public interface VoidType { }
}
11 changes: 1 addition & 10 deletions APIMatic.Core/Utilities/TestHelper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -503,16 +503,7 @@ private static bool DoesRightValContainsSameItems(JArray leftJArray, object righ

private static bool ListContainsJObject(JArray jArray)
{
bool containsJObject = false;
foreach (var item in jArray)
{
if (item is JObject)
{
containsJObject = true;
break;
}
}
return containsJObject;
return jArray.Any(item => item is JObject);
}

private static bool IsArrayOfJObject(JArray jArray)
Expand Down
2 changes: 1 addition & 1 deletion APIMatic.Core/Utilities/XmlUtility.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ public static List<T> NativeTypesArrayFromXml<T>(string text)

foreach (Match m in mc)
{
val = m.Value.TrimStart('>').TrimEnd(new char[] { '<', '/' });
val = m.Value.TrimStart('>').TrimEnd('<', '/');
list.Add((T)Convert.ChangeType(val, typeof(T)));
}

Expand Down