Skip to content

fix: handle duplicate parameters in request parameters #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 3, 2025
Merged

fix: handle duplicate parameters in request parameters #148

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion APIMatic.Core.Test/APIMatic.Core.Test.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
<PrivateAssets>all</PrivateAssets>
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
</PackageReference>
<PackageReference Include="SonarAnalyzer.CSharp" Version="8.51.0.59060">
<PackageReference Include="SonarAnalyzer.CSharp" Version="9.0.0.0000" >
<PrivateAssets>all</PrivateAssets>
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
</PackageReference>
Expand Down
2 changes: 1 addition & 1 deletion APIMatic.Core.Test/Http/HttpClientWrapperSSLTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ public async Task TestHttpClientSkipSSLCertificateVerification_OKResponse()
// Act
var actual = await client.ExecuteAsync(request);

Assert.AreEqual(actual.StatusCode, (int)HttpStatusCode.OK);
Assert.AreEqual((int)HttpStatusCode.OK, actual.StatusCode);
}
}
}
2 changes: 2 additions & 0 deletions APIMatic.Core.Test/MockTypes/Convertors/UnixDateTimeConverter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,7 @@ namespace APIMatic.Core.Test.MockTypes.Convertors
/// <summary>
/// Extends from DateTimeConverterBase, uses unix DateTime format.
/// </summary>
#pragma warning disable S2094
public class UnixDateTimeConverter : CoreUnixDateTimeConverter { }
#pragma warning restore S2094
}
2 changes: 1 addition & 1 deletion APIMatic.Core/APIMatic.Core.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@
<PrivateAssets>all</PrivateAssets>
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
</PackageReference>
<PackageReference Include="SonarAnalyzer.CSharp" Version="8.55.0.65544">
<PackageReference Include="SonarAnalyzer.CSharp" Version="9.0.0.0000" >
<PrivateAssets>all</PrivateAssets>
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
</PackageReference>
Expand Down
2 changes: 1 addition & 1 deletion APIMatic.Core/Request/Parameters/Parameter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ public abstract class Parameter

private string GetName() => key == "" ? typeName : key;

private string IdentifierKey => string.IsNullOrEmpty(key) ? $"_{nameof(Parameter)}_{Guid.NewGuid()}" : key;
private string IdentifierKey => string.IsNullOrEmpty(key) ? $"_{typeName}_{Guid.NewGuid()}" : $"_{typeName}_{key}";

public Parameter Setup(string key, object value)
{
Expand Down
2 changes: 1 addition & 1 deletion APIMatic.Core/Utilities/CoreHelper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,7 +262,7 @@ internal static bool TryGetInnerValueForContainer(object value, out dynamic inne
var valueType = value?.GetType();
if (valueType?.Namespace?.EndsWith(".Containers") == true)
{
innerValue = valueType.GetFields()[0].GetValue(value);
innerValue = valueType?.GetFields()[0].GetValue(value);
return true;
}
innerValue = null;
Expand Down
Loading