Skip to content

Conversation

@asadali214
Copy link
Collaborator

@asadali214 asadali214 commented Dec 23, 2023

What

This PR added support for the null values to pass while deserialization if none of the inner types are matched as the OAF containers are nullable by default

Why

We were required to resolve a critical deserialization issue

Closes #58

Type of change

Select multiple if applicable.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause a breaking change)
  • Tests (adds or updates tests)
  • Documentation (adds or updates documentation)
  • Refactor (style improvements, performance improvements, code refactoring)
  • Revert (reverts a commit)
  • CI/Build (adds or updates a script, change in external dependencies)

Dependency Change

If a new dependency is being added, please ensure that it adheres to the following guideline https://github.com/apimatic/apimatic-codegen/wiki/Policy-of-adding-new-dependencies-in-the-core-libraries

Breaking change

If the PR is introducing a breaking change, please ensure that it adheres to the following guideline https://github.com/apimatic/apimatic-codegen/wiki/Guidelines-for-maintaining-core-libraries

Testing

List the steps that were taken to test the changes

Checklist

  • My code follows the coding conventions
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added new unit tests

@asadali214 asadali214 self-assigned this Dec 23, 2023
@asadali214 asadali214 merged commit 95fe099 into main Dec 23, 2023
@asadali214 asadali214 deleted the 58-fix-null-oaf-deserialization branch December 23, 2023 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unable to deserialize a null value for a non-nullable OAF container

2 participants