Skip to content

fix(oneof-anyof-nulls): added fix for deserializing null values to oaf containers #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 23, 2023
Merged

fix(oneof-anyof-nulls): added fix for deserializing null values to oaf containers #59

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions APIMatic.Core.Test/Utilities/OneOfContainerTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,14 @@ public void TestNativeType()
});
}

[Test]
public void TestNativeTypeWithNullValue()
{
NativeOneOfContainer container = CoreHelper.JsonDeserialize<NativeOneOfContainer>("null");

Assert.IsNull(container);
}

[Test]
public void TestNativeNullableType()
{
Expand Down
6 changes: 6 additions & 0 deletions APIMatic.Core/Utilities/Converters/UnionTypeConverter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,12 @@ private T DeserializeOneOfAnyOf(JToken token, JsonSerializer serializer, List<Un
return mappedValues[0].value;
}

if (token.Type == JTokenType.Null)
{
// allow null values to pass as the OAF containers are nullable by default
return default;
}

if (_isOneOf)
{
throw new OneOfValidationException(unMappedTypes, token.ToString());
Expand Down