Skip to content

Conversation

@asadali214
Copy link
Collaborator

@asadali214 asadali214 commented Oct 18, 2023

What

This PR fixes a bug where we were serializing the boolean values as True and False instead of true and false while sending them in query string

Why

Although the query parameter values are case insensitive, but we need to make sure that the serialization across our tooling remain same

Type of change

Select multiple if applicable.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause a breaking change)
  • Tests (adds or updates tests)
  • Documentation (adds or updates documentation)
  • Refactor (style improvements, performance improvements, code refactoring)
  • Revert (reverts a commit)
  • CI/Build (adds or updates a script, change in external dependencies)

Dependency Change

If a new dependency is being added, please ensure that it adheres to the following guideline https://github.com/apimatic/apimatic-codegen/wiki/Policy-of-adding-new-dependencies-in-the-core-libraries

Breaking change

If the PR is introducing a breaking change, please ensure that it adheres to the following guideline https://github.com/apimatic/apimatic-codegen/wiki/Guidelines-for-maintaining-core-libraries

Testing

List the steps that were taken to test the changes

Checklist

  • My code follows the coding conventions
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added new unit tests

@asadali214 asadali214 added the bug Something isn't working label Oct 18, 2023
@asadali214 asadali214 self-assigned this Oct 18, 2023
@asadali214 asadali214 linked an issue Oct 18, 2023 that may be closed by this pull request
@asadali214 asadali214 merged commit ad755f8 into main Oct 18, 2023
@asadali214 asadali214 deleted the 54-boolean-serialization-lower-in-query branch October 18, 2023 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Prefer boolean serialization to lower casing instead of pascal

3 participants