Skip to content

Commit ad755f8

Browse files
authored
fix(bool-serialization-query): preferred true as the serializable bool value for query (#55)
1 parent 8e79426 commit ad755f8

File tree

2 files changed

+11
-10
lines changed

2 files changed

+11
-10
lines changed

APIMatic.Core.Test/Utilities/CoreHelperTest.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -457,7 +457,7 @@ public void AppendQueryParameter_CustomParameter()
457457
"serverResponse"
458458
};
459459

460-
string expected = $"{SERVER_URL}?serverResponse%5Bpassed%5D=True";
460+
string expected = $"{SERVER_URL}?serverResponse%5Bpassed%5D=true";
461461
CoreHelper.AppendUrlWithQueryParameters(queryBuilder, GetParameters(parametersKeys, serverResponse));
462462
string actual = queryBuilder.ToString();
463463
Assert.AreEqual(expected, actual);
@@ -626,7 +626,7 @@ public void AppendQueryParameter_CustomCollectionParameter()
626626
"serverResponse"
627627
};
628628

629-
string expected = $"{SERVER_URL}?serverResponse%5B0%5D%5Bpassed%5D=True";
629+
string expected = $"{SERVER_URL}?serverResponse%5B0%5D%5Bpassed%5D=true";
630630
CoreHelper.AppendUrlWithQueryParameters(queryBuilder, GetParameters(parametersKeys, stringCollection));
631631
string actual = queryBuilder.ToString();
632632
Assert.AreEqual(expected, actual);

APIMatic.Core/Utilities/CoreHelper.cs

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -519,20 +519,21 @@ private static string GetFormatString(ArraySerialization fmt, string key, String
519519

520520
private static string GetElementValue(object element, bool urlEncode)
521521
{
522-
string elemValue;
523522
if (element is DateTime time)
524523
{
525-
elemValue = time.ToString(DateTimeFormat);
526-
return elemValue;
524+
return time.ToString(DateTimeFormat);
527525
}
528-
else if (element is DateTimeOffset offset)
526+
527+
if (element is DateTimeOffset offset)
529528
{
530-
elemValue = offset.ToString(DateTimeFormat);
531-
return elemValue;
529+
return offset.ToString(DateTimeFormat);
532530
}
533-
else
531+
532+
string elemValue = element.ToString();
533+
534+
if (element is bool)
534535
{
535-
elemValue = element.ToString();
536+
elemValue = elemValue.ToLower();
536537
}
537538

538539
if (urlEncode)

0 commit comments

Comments
 (0)