Skip to content

Conversation

@hamzamahmood
Copy link
Collaborator

@hamzamahmood hamzamahmood commented Mar 30, 2023

The following PR updates the referred external packages in the core-lib and core-lib test projects to make sure that the C# core-lib is up-to-date and has the latest fixes and improvements.

Packages updated in APIMatic.Core:

  • Microsoft.Json.Pointer
  • Polly
  • SonarAnalyzer.CSharp
  • System.Collections.Immutable

Packages updated in APIMatic.Core.Test:

  • Microsoft.NET.Test.Sdk
  • NUnit3TestAdapter
  • SonarAnalyzer.CSharp

- VoidType converted to interface
- TestHelper ListContainsJObject refactored
@hamzamahmood hamzamahmood added the build Build system or external dependency changes label Mar 30, 2023
@hamzamahmood hamzamahmood requested a review from asadali214 March 30, 2023 08:46
@hamzamahmood hamzamahmood self-assigned this Mar 30, 2023
asadali214
asadali214 previously approved these changes Mar 31, 2023
Copy link
Collaborator

@asadali214 asadali214 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved!

asadali214
asadali214 previously approved these changes Apr 3, 2023
Copy link
Collaborator

@asadali214 asadali214 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved!

Copy link
Collaborator

@asadali214 asadali214 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@hamzamahmood hamzamahmood merged commit 69cbdd2 into main Apr 4, 2023
@asadali214 asadali214 deleted the 39-update-external-dependencies branch July 7, 2023 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Build system or external dependency changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants