Skip to content

Conversation

@hamzamahmood
Copy link
Collaborator

@hamzamahmood hamzamahmood commented Oct 1, 2025

What

  • Removed duplicate parameters in function and method definitions to ensure code correctness and maintainability.
  • Upgraded SonarAnalyzer.CSharp NuGet package to a newer, secure version to resolve known vulnerabilities (e.g., CVE-2021-22570 via Google.Protobuf dependency).

Why

  • Duplicate parameters can cause compilation errors or unpredictable behavior; eliminating them improves code reliability and clarity.
  • The previous version of SonarAnalyzer.CSharp included a vulnerable dependency. Upgrading ensures our static analysis tools do not introduce security risks in the build pipeline and complies with security best practices.

Type of change

Select multiple if applicable.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause a breaking change)
  • Tests (adds or updates tests)
  • Documentation (adds or updates documentation)
  • Refactor (style improvements, performance improvements, code refactoring)
  • Revert (reverts a commit)
  • CI/Build (adds or updates a script, change in external dependencies)

Dependency Change

SonarAnalyzer.CSharp package to Version="9.0.0.0000"

- upgrade SonarAnalyzer.CSharp to address security vulnerability
@hamzamahmood hamzamahmood self-assigned this Oct 1, 2025
@hamzamahmood hamzamahmood added the bug Something isn't working label Oct 1, 2025
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 1, 2025

@hamzamahmood hamzamahmood merged commit 596729f into main Oct 3, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants