Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rewrote utils.parseOpenGraph() so it can parse arrays of objects with properties. #2521

Draft
wants to merge 18 commits into
base: master
Choose a base branch
from

Conversation

daball
Copy link

@daball daball commented Jun 5, 2024

I updated the Open Graph Parser so that it can parse arrays of images with properties and present them as arrays of image objects with properties. There are other Open Graph meta tags which can also contain arrays of objects with properties, and this update does not address those (e.g. video, etc.), but it provides a template which works more specifically than the simpler code which is still featured. This update is neither fully generalized nor fully specialized but presents another way to do it. This new code still passes the old tests and the new test, but I can imagine many other test cases which will still fail without additional work on this module. As long as everyone is okay with this approach I can work on it further.

@daball
Copy link
Author

daball commented Jun 6, 2024

I did some more work on the Open Graph parser. Let me know if you need any other changes.

@janbuchar
Copy link
Contributor

Hello @daball, and thanks for your contribution! Is this ready for review or are you planning to work on it more? If it's not ready, please convert it to draft 🙂

@daball
Copy link
Author

daball commented Jun 7, 2024

Hello @daball, and thanks for your contribution! Is this ready for review or are you planning to work on it more? If it's not ready, please convert it to draft 🙂

I think it's ready. But because I know it's not finished, I will reluctantly go back to draft. And because I don't like that it's not finished. It needs more test cases and it needs me to finish the conversion and also to probably break the API just a little further. And I need a couple more days to finish it.

@daball daball marked this pull request as draft June 7, 2024 16:28
@daball daball changed the title fix: utils.parseOpenGraph() can parse arrays of images with properties. fix: rewrote utils.parseOpenGraph() so it can parse arrays of objects with properties. Jun 7, 2024
@B4nan B4nan added the t-tooling Issues with this label are in the ownership of the tooling team. label Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t-tooling Issues with this label are in the ownership of the tooling team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants