Skip to content

fix: prevent reboot loops #345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fnesveda merged 1 commit into from
Dec 19, 2024
Merged

fix: prevent reboot loops #345

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions packages/apify/src/actor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,11 @@ export class Actor<Data extends Dictionary = Dictionary> {
*/
private warnedAboutMissingInitCall = false;

/**
* Set if the Actor is currently rebooting.
*/
private isRebooting = false;

constructor(options: ConfigurationOptions = {}) {
// use default configuration object if nothing overridden (it fallbacks to env vars)
this.config = Object.keys(options).length === 0 ? Configuration.getGlobalConfig() : new Configuration(options);
Expand Down Expand Up @@ -459,6 +464,13 @@ export class Actor<Data extends Dictionary = Dictionary> {
return;
}

if (this.isRebooting) {
log.debug('Actor is already rebooting, skipping the additional reboot call.');
return;
}

this.isRebooting = true;

// Waiting for all the listeners to finish, as `.reboot()` kills the container.
await Promise.all([
// `persistState` for individual RequestLists, RequestQueue... instances to be persisted
Expand Down
Loading