Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

expose parseSource #109

Merged
merged 2 commits into from
Oct 29, 2020
Merged

expose parseSource #109

merged 2 commits into from
Oct 29, 2020

Conversation

woodgear
Copy link
Contributor

No description provided.

@woodgear woodgear mentioned this pull request Oct 27, 2020
Closed
@woodgear
Copy link
Contributor Author

@tommy87 @NicolasCARPi i

@NicolasCARPi
Copy link
Collaborator

Thanks @woodgear I'll test it out and merge when I have time.

NicolasCARPi
NicolasCARPi reviewed Oct 28, 2020
View reviewed changes
test/parse_source_test.js Outdated
var apidoc = require("../lib/index");

function log() {
// console.log(arguments);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this left commented on purpose? Do we even need to specify a logger in the tests?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no,i just forget to delete this line, i will update later.
yes,because if we do not setLogger this line will report error,because of #105

@NicolasCARPi NicolasCARPi merged commit 6f25fac into apidoc:dev Oct 29, 2020
@NicolasCARPi
Copy link
Collaborator

Thank you for your contribution @woodgear and thanks @tommy87 for helping out! :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@NicolasCARPi NicolasCARPi NicolasCARPi left review comments

@tommy87 tommy87 tommy87 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@woodgear @NicolasCARPi @tommy87