ci: Using Buildx as Docker builder #74
Conversation
|
|
qsliu2017
changed the title
Hi @qsliu2017 , you can follow the Instruction to sigh the CLA, thanks |
There was a problem hiding this comment.
@qsliu2017 Hi, sorry for being late. Could you please add a test case for this new parameter within the current CI before merging?
For example, in https://github.com/api7/apisix-build-tools/blob/master/.github/workflows/package-apisix-rpm-el7.yml, we could change make package type=rpm app=apisix version=2.7 checkout=release/2.7 image_base=centos image_tag=7 artifact=apisix-remote to make package type=rpm app=apisix version=2.7 checkout=release/2.7 image_base=centos image_tag=7 artifact=apisix-remote buildx=true to run the testing.
Your patience is much appreciated.
Makefile
Outdated
| ### function for building | ||
| ### $(1) is name | ||
| ### $(2) is dockerfile filename | ||
| ### $(3) is package type | ||
| ### $(4) is code path | ||
| ifneq ($(buildx), "true") |
There was a problem hiding this comment.
@qsliu2017 The https://github.com/api7/apisix-build-tools/pull/74/checks?check_run_id=3520664903#step:6:6 showed that the buildx=true didn't work as expected. So I guess you should change this to ifneq ($(buildx), true). Thanks.
There was a problem hiding this comment.
@qsliu2017 Hi, in plan we are going to prepare for a new release. Since your PR will significantly reduce the CI time, would you mind make the above changes ASAP? Much appreciated.
When I try to optimize apisix-dashboard's CI, I find that the build script in this repo is a reason for slow CI. As discuss in apache/apisix-dashboard#2072, using buildx can cache Docker layers and so speed up CI.