ci: revert artifact-quota mitigations now that storage budget is set - #42
Merged
Conversation
The Packages spending limit on the moonming account was raised from $0 to $5/mo (artifact storage is billed under the Packages SKU, not Actions). Verified by re-running run 24948385951: build-ui's upload-artifact step no longer reports "Artifact storage quota has been hit", and downstream build-aisix can now download ui-dist. Reverts the four `continue-on-error` mitigations added by: - #40: rust-unit's coverage-unit upload-artifact build-ui's ui-dist upload-artifact build-bin (build-aisix) job-level - #41: coverage-gate job-level coverage-gate's coverage-unit download-artifact Preserves the two pre-existing `continue-on-error` markers that predate the quota outage: - e2e job-level (etcd service startup / undici flake) - coverage-gate's coverage-e2e download-artifact (e2e produces no coverage when its tests don't run)
There was a problem hiding this comment.
Pull request overview
Reverts CI “soft-fail” mitigations that were introduced to work around GitHub artifact storage quota errors, now that the account’s Packages budget has been raised and artifact uploads/downloads are expected to be reliable again.
Changes:
- Remove
continue-on-errorfromcoverage-unitartifact upload inrust-unit. - Remove
continue-on-errorfromui-distartifact upload inbuild-ui. - Remove job-level
continue-on-errorfrombuild-binandcoverage-gate, and makecoverage-unitdownload hard-fail again incoverage-gate.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Packages spending limit on the moonming account was raised from $0 → $5/mo (artifact storage is billed under the Packages SKU, not Actions). Verified empirically: re-running run 24948385951, build-ui's upload-artifact step no longer hits "Artifact storage quota has been hit" and downstream build-aisix successfully downloads ui-dist.
Time to remove the soft-fail mitigations.
What's reverted
Four `continue-on-error` markers from #40 + #41:
What's preserved
Two pre-existing markers that predate the quota issue:
Test plan