Skip to content

ci: soft-fail coverage-gate while artifact quota persists #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
moonming merged 1 commit into from
Apr 26, 2026
Merged

ci: soft-fail coverage-gate while artifact quota persists #41

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,9 +211,17 @@ jobs:
name: coverage >= 90%
needs: [rust-unit, e2e]
runs-on: ubuntu-latest
# The threshold check itself is already a soft gate (the bash logic
# exits 0 even when below threshold; see comment on the merge step).
# Aligning the job-level setting with that intent: don't fail the
# workflow when coverage-gate fails — especially while the artifact
# storage quota outage prevents the upstream coverage-unit upload.
# Revert when the gate is flipped from advisory to gating (PR #5).
continue-on-error: true
Comment on lines +217 to +220

Copilot AI Apr 26, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new comment says to “Revert when the gate is flipped … (PR #5)”, but PR #5 (per this PR’s metadata) is about server startup/health listeners and doesn’t appear related to coverage gating. Consider removing the PR reference or linking to the correct tracking issue/PR so future readers know when to revert.

Copilot uses AI. Check for mistakes.
steps:
- uses: actions/checkout@v4
- uses: actions/download-artifact@v4
continue-on-error: true
with: { name: coverage-unit, path: cov/unit }
Comment on lines 223 to 225

Copilot AI Apr 26, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

continue-on-error on the download-artifact step lets the job proceed, but the later merge script still assumes cov/unit/*.info exists (files=(cov/unit/*.info) + cp "${files[0]}" ...). When the unit artifact is missing, Bash will keep the literal glob, causing lcov-result-merger/cp to fail and the subsequent upload step to be skipped. Please make the merge step tolerate missing/empty artifacts (e.g., enable nullglob and build the files array only from existing matches, or explicitly handle the empty case).

Copilot uses AI. Check for mistakes.
- uses: actions/download-artifact@v4
continue-on-error: true
Expand Down
Loading