-
Notifications
You must be signed in to change notification settings - Fork 29
feat(managed): one-shot /dp/register client + atomic cert persistence #30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -43,3 +43,8 @@ thiserror.workspace = true | |||||||||
| anyhow.workspace = true | ||||||||||
| tracing.workspace = true | ||||||||||
| etcd-client.workspace = true | ||||||||||
| reqwest.workspace = true | ||||||||||
|
|
||||||||||
| [dev-dependencies] | ||||||||||
| tempfile = "3" | ||||||||||
| wiremock = "0.6" | ||||||||||
|
Comment on lines
+49
to
+50
|
||||||||||
| tempfile = "3" | |
| wiremock = "0.6" | |
| tempfile.workspace = true | |
| wiremock.workspace = true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Docs vs behavior: this comment says the
mtls_dirparent directory must already exist, butpersist_mtls()currently callscreate_dir_all. Either update the documentation to match (directory will be created) or change the code to enforce the documented requirement.