fix(doctrine): memory leak when using the iterator mongodb#6878
Closed
soyuka wants to merge 1 commit intoapi-platform:3.4from
Closed
fix(doctrine): memory leak when using the iterator mongodb#6878soyuka wants to merge 1 commit intoapi-platform:3.4from
soyuka wants to merge 1 commit intoapi-platform:3.4from
Conversation
GromNaN
reviewed
Dec 18, 2024
|
|
||
| private readonly int $count; | ||
|
|
||
| public function __construct(private readonly Iterator $mongoDbOdmIterator, private readonly UnitOfWork $unitOfWork, private readonly string $resourceClass, private readonly array $pipeline) |
Contributor
There was a problem hiding this comment.
You can forget it.
Suggested change
| public function __construct(private readonly Iterator $mongoDbOdmIterator, private readonly UnitOfWork $unitOfWork, private readonly string $resourceClass, private readonly array $pipeline) | |
| public function __construct(Iterator $mongoDbOdmIterator, private readonly UnitOfWork $unitOfWork, private readonly string $resourceClass, private readonly array $pipeline) |
Member
Author
|
Should've been fixed by doctrine/mongodb-odm#2709 ? |
Contributor
|
I think this is still a relevant change. It frees up the cursor and its stacked iterators, from the memory, to keep only the results as an array, before starting another memory-consuming job: hydration. |
Contributor
|
This PR can be closed, as #6912 did the same. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.