fix(openapi): Yaml openapi export should have numeric keys as string #6436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DartCZ
changed the title
DartCZ
force-pushed
the
fix/openapi-export-yaml-should-numeric-key-as-string
branch
3 times, most recently
from
d46a59f to
4324754
Compare
soyuka
force-pushed
the
fix/openapi-export-yaml-should-numeric-key-as-string
branch
from
4324754 to
5a47d5a
Compare
soyuka
force-pushed
the
fix/openapi-export-yaml-should-numeric-key-as-string
branch
from
5a47d5a to
ede5bf5
Compare
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The OpenAPI specification mandates that all keys in the Responses Object be strings, as outlined here: https://github.com/OAI/OpenAPI-Specification/blob/157a4c81ae537ef793b2bee368bc00d88b461de8/versions/3.0.2.md#patterned-fields-1.
This requirement includes values like '200', which PHP typecasts to integers. Therefore, Yaml should also adhere to this rule.