Fix: Inconsistency in Context Concatenation with fetch_data

[anoziere]

Q	A
Branch?	current stable version branch for bug fixes
Tickets	Closes #2594
License	MIT
Doc PR	N/A

I have noticed an inconsistency in the ItemNormalizer.php file regarding the handling of the $context array in the updateObjectToPopulate method.

In the try block, the context is concatenated with ['fetch_data' => true] when calling getResourceFromIri. However, in the corresponding catch block for LegacyInvalidArgumentException|InvalidArgumentException, the same concatenation with fetch_data is not performed when setting the OBJECT_TO_POPULATE in the context:

// In try block
$context[self::OBJECT_TO_POPULATE] = $this->iriConverter->getResourceFromIri(
    (string) $data['id'], 
    $context + ['fetch_data' => true]
);

// In catch block
$context[self::OBJECT_TO_POPULATE] = $this->iriConverter->getResourceFromIri(
    $iri, 
    ['fetch_data' => true]
);

so I just added the context in the case of catch.

[soyuka]

I'm really unsure about that, also you're using json right?

[anoziere]

I'm really unsure about that, also you're using json right?

Yes, we encountered this issue while using JSON in a project where we integrated API Platform as an additional layer. We had to redo quite a bit (the project in question is based on Propel), but we faced this issue when using a PUT request and in the context of returning the modified object.

I don't understand why the context would be different in this case. Is there a specific constraint that leads to only having fetch_data in this case?

[soyuka]

had to add a test and reword your commit please look at our commit rules inside CONTRIBUTING next time, thanks for the patch!