Skip to content

Conversation

@BenoitLeveque
Copy link

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #555
License MIT
Doc PR

We can't use api-platform 1.1 with symfony 3. here is a fix to allow both version of phpdocumentator/reflection

With this we should be able to use symfony 3.1
see issue api-platform#555
@BenoitLeveque BenoitLeveque changed the title Allow the latest version of phpdocumentor/reflection [WIP] Allow the latest version of phpdocumentor/reflection May 30, 2016
@dunglas
Copy link
Member

dunglas commented May 31, 2016

Do you have tested it? I can't believe that it works without having to modify the code and create an adapter like in phpspec/prophecy#275


use Dunglas\ApiBundle\Mapping\ClassMetadata;
use Dunglas\ApiBundle\Util\ReflectionTrait;
use phpDocumentor\Reflection\ClassReflector;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this change?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The use was missing

@BenoitLeveque
Copy link
Author

I close the as that's doesn't fix my issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants