-
-
Notifications
You must be signed in to change notification settings - Fork 895
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade the Negotiation library #1104
Conversation
create new tag ASAP, because after composer update you get willdurand/negotiation v 2.3 and after that will work only first output normalizer with same format (e.g. json)
request: |
We're aware of that @insekticid this is why the version should have been patched in #1102! See the root cause here. We're waiting for this to be merged to fix the issue :). |
I understand, but you should add warning to Api Platform website, or create new Api Platform Core tag 2.0.8 with '"willdurand/negotiation": "^2.0.3 <2.3",' until this will be fixed |
The new tag is here, this PR can be updated! |
Hmm we have the same phpstan errors then in #1113 |
@dunglas could you set up a new tag (also in api-platform/api-platform)? Thanks! |
@soyuka why? |
Composer should take the last available version of the negotation library? If that's the case, never mind ;). |
@soyuka yep. And when doing |
@dunglas Bumping the required version of I believe it should be: "willdurand/negotiation": "^2.0.3 <2.3 || ^2.3.1", |
I haven't seen this PR was merged. There is no need to do that as a new version of a new version of |
Yeah sorry my bad, thought it was needed. I've reverted it in #1115 |
Upgrade the Negotiation library
See willdurand/Negotiation#94
TODO: