-
Notifications
You must be signed in to change notification settings - Fork 401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Carbtest patch 1 #445
base: master
Are you sure you want to change the base?
Carbtest patch 1 #445
Conversation
update phpcas
Deprecated: phpCAS::client(): Implicitly marking parameter $sessionHandler as nullable is deprecated, the explicit nullable type must be used instead
These changes will fix: PHP8.4 issues Deprecated: phpCAS::proxy(): Implicitly marking parameter $sessionHandler as nullable is deprecated, the explicit nullable type must be used instead in /vendor/apereo/phpcas/source/CAS.php on line 403 Deprecated: CAS_Client::__construct(): Implicitly marking parameter $sessionHandler as nullable is deprecated, the explicit nullable type must be used instead in /vendor/apereo/phpcas/source/CAS/Client.php on line 933 |
Really hope someone who has the ability to integrate this change will do so. Tested and confirmed it works with PHP 8.4. The changes are so simple...please someone release a phpCAS 1.6.2 version with these simple changes for PHP 8.4 support. It's been 3 months since PHP 8.4 was officially released and we all need this updated version with PHP 8.4 support. |
This repo is no longer maintained, we will have to fork it or modify our local version ;( |
From what I read here: https://groups.google.com/a/apereo.org/g/cas-user/c/7A4MKl6DIOk/m/WikoKAJ2AgAJ |
We're going to try this after talking with the original developer of phpCAS who unfortunately stepped down and gave back all his privileges last year... @phy25 Can you help us get this PR approved? Joachim said that you may still have commit privileges. You would make lots of people very happy if you could get this very simple change approved. Thank you! |
+1 for this. One of my client is upgrading to PHP8.4 and would profit from this change. I can help to merge / release if needed. Not sure I have time to improve all the code but at least I could maintain compatibility with PHP versions. |
Much Appreciated
From: Pierrick Charron ***@***.***>
Sent: Wednesday, March 19, 2025 11:44 AM
To: apereo/phpCAS ***@***.***>
Cc: Web Master ***@***.***>; Author ***@***.***>
Subject: Re: [apereo/phpCAS] Carbtest patch 1 (PR #445)
+1 for this. One of my client is upgrading to PHP8.4 and would profit from this change. I can help to merge / release if needed. Not sure I have time to improve all the code but at least I could maintain compatibility with PHP versions.
—
Reply to this email directly, view it on GitHub<#445 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/A6CG2TUS4YZLL4RQDFLVNLD2VG3GFAVCNFSM6AAAAABXDCICWOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOMZXGY4DAMRZGI>.
You are receiving this because you authored the thread.Message ID: ***@***.******@***.***>>
[adoy]adoy left a comment (apereo/phpCAS#445)<#445 (comment)>
+1 for this. One of my client is upgrading to PHP8.4 and would profit from this change. I can help to merge / release if needed. Not sure I have time to improve all the code but at least I could maintain compatibility with PHP versions.
—
Reply to this email directly, view it on GitHub<#445 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/A6CG2TUS4YZLL4RQDFLVNLD2VG3GFAVCNFSM6AAAAABXDCICWOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOMZXGY4DAMRZGI>.
You are receiving this because you authored the thread.Message ID: ***@***.******@***.***>>
|
Here's from the CAS primary maintainer after reaching out to see if he could help:
He maintains CAS itself. phpCAS is not his project and he's never done anything with this project, so I don't fault him in any way and appreciate that he took the time to reply to my email. If someone wants to reach out to Apereo themselves and try to get rights to maintain this phpCAS project going forward, go for it. Good luck to anyone with more skills that can continue this project, hate to see it go away, but I'm at the extent of my abilities, so I hope someone reaches out to the Apereo group (https://www.apereo.org/contact) and can save this project. |
No description provided.