Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Carbtest patch 1 #445

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Carbtest patch 1 #445

wants to merge 4 commits into from

Conversation

carbtest
Copy link
Contributor

No description provided.

Deprecated: phpCAS::client(): Implicitly marking parameter $sessionHandler as nullable is deprecated, the explicit nullable type must be used instead
@carbtest
Copy link
Contributor Author

carbtest commented Feb 13, 2025

These changes will fix: PHP8.4 issues
Deprecated: phpCAS::client(): Implicitly marking parameter $sessionHandler as nullable is deprecated, the explicit nullable type must be used instead in /vendor/apereo/phpcas/source/CAS.php on line 348

Deprecated: phpCAS::proxy(): Implicitly marking parameter $sessionHandler as nullable is deprecated, the explicit nullable type must be used instead in /vendor/apereo/phpcas/source/CAS.php on line 403

Deprecated: CAS_Client::__construct(): Implicitly marking parameter $sessionHandler as nullable is deprecated, the explicit nullable type must be used instead in /vendor/apereo/phpcas/source/CAS/Client.php on line 933

@rutgers-master
Copy link

Really hope someone who has the ability to integrate this change will do so. Tested and confirmed it works with PHP 8.4. The changes are so simple...please someone release a phpCAS 1.6.2 version with these simple changes for PHP 8.4 support. It's been 3 months since PHP 8.4 was officially released and we all need this updated version with PHP 8.4 support.

@carbtest
Copy link
Contributor Author

carbtest commented Mar 5, 2025

Really hope someone who has the ability to integrate this change will do so. Tested and confirmed it works with PHP 8.4. The changes are so simple...please someone release a phpCAS 1.6.2 version with these simple changes for PHP 8.4 support. It's been 3 months since PHP 8.4 was officially released and we all need this updated version with PHP 8.4 support.

This repo is no longer maintained, we will have to fork it or modify our local version ;(

@rutgers-master
Copy link

rutgers-master commented Mar 6, 2025

From what I read here: https://groups.google.com/a/apereo.org/g/cas-user/c/7A4MKl6DIOk/m/WikoKAJ2AgAJ
They are still willing to review PRs... Fingers crossed someone does....

@rutgers-master
Copy link

We're going to try this after talking with the original developer of phpCAS who unfortunately stepped down and gave back all his privileges last year...

@phy25 Can you help us get this PR approved? Joachim said that you may still have commit privileges. You would make lots of people very happy if you could get this very simple change approved. Thank you!

@adoy
Copy link
Contributor

adoy commented Mar 19, 2025

+1 for this. One of my client is upgrading to PHP8.4 and would profit from this change. I can help to merge / release if needed. Not sure I have time to improve all the code but at least I could maintain compatibility with PHP versions.

@carbtest
Copy link
Contributor Author

carbtest commented Mar 19, 2025 via email

@rutgers-master
Copy link

rutgers-master commented Mar 21, 2025

Here's from the CAS primary maintainer after reaching out to see if he could help:

I am in no position and possess no relevant skill to review, comment, accept or merge changes, and certainly in no position to release the project. Furthermore, I have no time to spend on these tasks, and at the moment it seems to me that we don't really have a designated replacement in the community with a good enough proven reputation and needed time commitment to carry the torch going forward and be granted access.

I don't quite know the protocol is here; all I can suggest atm is, you can fork the repository and treat it just as any other open source project that is unsustained, not funded and therefore unmaintained and abandoned/stable. You can reach out to the Apereo foundation and discuss this with them. If their decision is that person X is to be given the rights to maintain the project going forward, I can help with that or Apereo itself can.

He maintains CAS itself. phpCAS is not his project and he's never done anything with this project, so I don't fault him in any way and appreciate that he took the time to reply to my email. If someone wants to reach out to Apereo themselves and try to get rights to maintain this phpCAS project going forward, go for it.

Good luck to anyone with more skills that can continue this project, hate to see it go away, but I'm at the extent of my abilities, so I hope someone reaches out to the Apereo group (https://www.apereo.org/contact) and can save this project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants