perf: avoid arrow IPC & unneeded steps when flushing delta #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 5 out of 5 changed files in this pull request and generated no suggestions.
Comments skipped due to low confidence (1)
binlogreplication/binlog_replica_applier.go:1248
- The new behavior introduced by the 'conn' parameter should be covered by tests to ensure it works as expected.
conn, err := adapter.GetConn(ctx)
There was a problem hiding this comment.
Copilot reviewed 6 out of 8 changed files in this pull request and generated no suggestions.
Files not reviewed (2)
- binlogreplication/writer.go: Evaluated as low risk
- replica/replication.go: Evaluated as low risk
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the approach for passing the delta buffer from Go to DuckDB. Previously, we used the
scan_arrow_ipcfunction provided by DuckDB's Arrow extension (https://github.com/duckdb/arrow), which required serializing Arrow arrays into Arrow IPC buffers.We now switch to go-duckdb's
RegisterViewAPI (introduced in marcboeker/go-duckdb#283), enabling zero-copy ingestion for improved efficiency.However, I observed that this API does not work as expected when only a subset of columns is needed on the DuckDB side. This issue might be related to a bug in DuckDB's projection pushdown implementation for Arrow data. As a workaround, I have implemented column pruning in advance to exclude unnecessary columns.