fix: don't ignore not found error in its controller #9823
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Auto Cherry-pick Instructions |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9823 +/- ##
==========================================
+ Coverage 59.67% 59.71% +0.03%
==========================================
Files 551 551
Lines 59786 59786
==========================================
+ Hits 35679 35701 +22
+ Misses 20848 20826 -22
Partials 3259 3259
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
github-actions
bot
added
size/S
leon-inf
reviewed
Oct 22, 2025
leon-inf
reviewed
Oct 23, 2025
|
|
||
| func (b *PlanBuilder) createObject(ctx context.Context, vertex *model.ObjectVertex) error { | ||
| err := b.cli.Create(ctx, vertex.Obj, clientOption(vertex)) | ||
| if err != nil && !apierrors.IsAlreadyExists(err) { |
There was a problem hiding this comment.
The IsAlreadyExists error should be ignored too.
There was a problem hiding this comment.
You mean should NOT be ingored? I think ignoring IsAlreadyExists is safe. And similarly, I think ignoring IsNotFound in delete operations is also safe.
| } | ||
| if len(finalizer) > 0 && controllerutil.RemoveFinalizer(vertex.Obj, finalizer) { | ||
| err := b.cli.Update(ctx, vertex.Obj, clientOption(vertex)) | ||
| if err != nil && !apierrors.IsNotFound(err) { |
| } | ||
| if !model.IsObjectDeleting(vertex.Obj) { | ||
| err := b.cli.Delete(ctx, vertex.Obj, clientOption(vertex)) | ||
| if err != nil && !apierrors.IsNotFound(err) { |
| if err != nil && !apierrors.IsNotFound(err) { | ||
| b.transCtx.logger.Error(err, fmt.Sprintf("delete %T error: %s", vertex.Obj, vertex.Obj.GetName())) | ||
| return err | ||
| b.transCtx.logger.Error(err, fmt.Sprintf("delete %T error: %s", vertex.Obj, klog.KObj(vertex.Obj))) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When kb enables IN_PLACE_POD_VERTICAL_SCALING feature gate, but k8s does not, a vscale operation may fail in its because kube-apiserver does not have the "resize" subresource. ITS controller should error emit a warning event like:
But instead, its controller silently ignores this error and makes the reconcilation successful.