-
Notifications
You must be signed in to change notification settings - Fork 240
feat: add hostPorts support to component network configuration #9820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Auto Cherry-pick Instructions |
|
It took me some fiddling to get the project running, but I was able to confirm that this change does behave properly. |
👍🏻 You can set the network.hostNetwork to true instead of adding the annotation. |
Thanks. Let me know if anything else is required before merging. |
| // This will override the container ports defined in component definition. | ||
| // | ||
| // +optional | ||
| HostPorts []HostPortPort `json:"hostPorts,omitempty"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The API should clarify whether all host-network ports need to be specified. Also, if not, what is the default behavior of other ports.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In addition, how should the ports built into the KB be specified? For example, the HTTP port of kbagent.
| Discrete []int32 `json:"discrete,omitempty"` | ||
| } | ||
|
|
||
| type HostPortPort struct { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
HostPort or HostPortPort?
leon-inf
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The resolving to host-network ports in Vars also needs to be modified.
fix #9818