Fix branded desktop artifact paths - #11
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Changing the Desktop product name to ApeMind Agent changed Electron Forge output directories to
ApeMind Agent-*. The release workflows still looked forGoose-*output paths, which broke the unsigned macOS Desktop PoC jobs and could also break Windows packaging.What
GOOSE_BUNDLE_NAME=ApeMind Agentin both macOS bundle workflows so the package scripts generate branded app bundles and zip names consistently.ApeMind Agent-darwin-*/ApeMind Agent.app.ApeMind Agent-win32-x64while keeping the executable and zip artifact name asGoosefor the deferred CLI/executable rename.ApeMind Agent*.zipmacOS assets.ApeMind Agent.app.Validation
git diff --checkout/Goose-darwin*,Goose.app,Goose.zip,Goose_intel_mac, orout/Goose-win32workflow paths.