Conversation
address the problems with the boxrestore test errors. - Update box2001 so it's bit-for-bit with different blocks/decomps/pe counts. - Initialize bathymetry values at all gridcells when bathymetry_format='default' and use_bathymetry=.false.
…non-zero values over land by default and this causes problems with land block elimination and comparisons of different decompositions. Does not affect science. - Update omp_suite to use different block sizes in comparisons
apcraig
requested review from
JFLemieux73,
dabail10,
eclare108213 and
phil-blain
eclare108213
approved these changes
Mar 9, 2022
| uocn(i,j,iblk) = p2*real(jglob(j), kind=dbl_kind) & | ||
| / real(ny_global,kind=dbl_kind) - p1 | ||
| vocn(i,j,iblk) = -p2*real(iglob(i), kind=dbl_kind) & | ||
| / real(nx_global,kind=dbl_kind) + p1 |
Collaborator
There was a problem hiding this comment.
This change is BFB on square domains -- but definitely fixing a bug in the denominators, thanks for catching it.
Owner
Author
There was a problem hiding this comment.
Yes, I also noticed the bug in the forcing, not just when I was reviewing the paper. So it wasn't working on multiple blocks and the forcing was incorrect.
| depth(k) = depth(k-1) + thick(k) | ||
| enddo | ||
|
|
||
| bathymetry = 0._dbl_kind |
Owner
Author
There was a problem hiding this comment.
Brain freeze, I'll fix it.
Owner
Author
|
Full suite results on cheyenne, https://github.com/CICE-Consortium/Test-Results/wiki/cice_by_hash_forks#090aa9280b9c91d648f07da5802307724983a13c All tests pass. The following difference exist with current main
The following are known problems
|
dabail10
approved these changes
Mar 10, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
Fix box2001 forcing, restart fields on land, bathymetry default value, omp_suite
apcraig
Full test suites run on cheyenne, results as expected
These changes should be migrated to main sooner than later.