Skip to content

Merge CICE-Consortium #8322416793ae2b76c2 Aug 18, 2023 and Update Icepack to E3SM Icepack #e7510221a315ab Aug 21, 2023#110

Merged
apcraig merged 10 commits into
E3SMIcepackDEVfrom
e3smup2
Aug 22, 2023
Merged

Merge CICE-Consortium #8322416793ae2b76c2 Aug 18, 2023 and Update Icepack to E3SM Icepack #e7510221a315ab Aug 21, 2023#110
apcraig merged 10 commits into
E3SMIcepackDEVfrom
e3smup2

Conversation

@apcraig
Copy link
Copy Markdown
Owner

@apcraig apcraig commented Aug 21, 2023

PR checklist

  • Short (1 sentence) summary of your PR:
    Merge CICE-Consortium #8322416793ae2b76c2 Aug 18, 2023 and Update Icepack to E3SM Icepack #e7510221a315ab Aug 21, 2023
  • Developer(s):
    apcraig
  • Suggest PR reviewers from list in the column to the right.
  • Please copy the PR test results link or provide a summary of testing completed below.
    Full test suite run on cheyenne, all tests pass, bit-for-bit with CICE Consortium main in log files, restarts are not identical due to changes in file (not model, as expected).
  • How much do the PR code changes differ from the unmodified code?
    • bit for bit
    • different at roundoff level
    • more substantial
  • Does this PR create or have dependencies on Icepack or any other models?
    • Yes
    • No
  • Does this PR update the Icepack submodule? If so, the Icepack submodule must point to a hash on Icepack's main branch.
    • Yes, updates Icepack to E3SM branch
    • No
  • Does this PR add any new test cases?
    • Yes
    • No
  • Is the documentation being updated? ("Documentation" includes information on the wiki or in the .rst files from doc/source/, which are used to create the online technical docs at https://readthedocs.org/projects/cice-consortium-cice/. A test build of the technical docs will be performed as part of the PR testing.)
    • Yes
    • No, does the documentation need to be updated at a later time?
      • Yes
      • No
  • Please provide any additional information or relevant details below:

dabail10 and others added 10 commits June 20, 2023 08:54
* Fix for mesh check in CESM driver

* Slightly different way to evaluate longitude difference

* Slightly different way to evaluate longitude difference

* Put the abs inside the mod

* Add abort calls back in
* update readthedocs.yaml, turn on pdf

* update readthedocs.yaml, turn on pdf

* update readthedocs.yaml, turn on pdf

* update readthedocs.yaml, turn on pdf
* Add option to change location in interval of time axis

* Only use hist_time_axis when hist_avg is true

* Add more comments and information in the documentation

* Add a check on hist_time_axis as well as a global attribute

* Abort if hist_time_axis is not set correctly.
Remove deprecated COREII LYq forcing

Remove deprecated print_points_state

Update links in rst documentation to point to main, not master
* updating paths for local nrlssc builds

* Add jra55do forcing option

* Updated env.nrlssc_gnu for new local directory structure

* Added JRA55do to file names. Added comments for each variable name at top of JRA55do_???_files subroutine

* Make JRA55 forcing to use common subroutines. Search atm_data_type for specific cases

* remove extraneous 'i' variable in JRA55_files

* Changed JRA55 filename JRA55_grid instead of grid at end of filename

* Add jra55do tests to base_suite and quick_suite. This is done via set_nml options.

* Update forcing implementation to provide a little more flexibility for
JRA55, JRA55do, and ncar bulk atm forcing files.

* Update documentation

* update Onyx port

* Update forcing documentation

Initial port to derecho_intel

* clean up blank spaces

---------

Co-authored-by: daveh150 <david.hebert@nrlssc.navy.mil>
…tium#846)

- fix optional arguments issues
- fix hsn_new(1) bug

Update optargs unit test, add new test cases

Add opticep unit test, to test CICE calls to Icepack without optional arguments.
Add new comparison option to comparelog.csh to compare a unit test with
a standard CICE test.

Update unittest_suite

Update documentation about optional arguments and unit tests
…al remapping (CICE-Consortium#833)

* Use same method whether l_fixed_area=T or F to compute masks for edge fluxes

* Corrected typo in comment

* Cosmetic (indentation) change in ice_transport_remap.F90

* Set l_fixed_area value depending of grid type

* Modifs to the doc for l_fixed_area

* Use umask for uvel,vvel initialization for boxslotcyl and change grid avg type from S to A in init_state

* Temporary changes before next PR: l_fixed_area=F for B and C grid

* Temporary changes before next PR: remove paragraph in the doc

* Small modifs: l_fixed_area and grid_ice are defined in module ice_transport_remap
…Consortium#853)

* test ghactions

* update master to main in github actions
* Replace tr_snow flag with snwredist, snwgrain in some places (tr_snow is still used more generally).  Fix intent(out) compile issue in ice_read_write.F90. Replace badger with chicoma machine files.

* update icepack to 86cae16d1b7c4c4f8

---------

Co-authored-by: apcraig <anthony.p.craig@gmail.com>
…3SMIcepackDEV

Merge CICE-Consortium #8322416793ae2b76c2 Aug 18, 2023 and Update Icepack to E3SM Icepack #e7510221a315ab Aug 21, 2023
@apcraig apcraig merged commit 5f84e7a into E3SMIcepackDEV Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants