forked from apache/kafka
-
Notifications
You must be signed in to change notification settings - Fork 0
KAFKA-19535: add integration tests for DescribeProducersOptions#brokerId #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
apalan60
wants to merge
6
commits into
trunk
Choose a base branch
from
KAFKA-19535
base: trunk
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
2a119a7
KAFKA-19535: add integration tests for DescribeProducersOptions#brokerId
apalan60 03708d3
Address comments
apalan60 107c9d5
refactor: extract helper method for brokerID retrieval
apalan60 e4cadae
Merge remote-tracking branch 'upstream/trunk' into KAFKA-19535
apalan60 5d7ccd4
Address comments
apalan60 b89cc95
Merge remote-tracking branch 'upstream/trunk' into KAFKA-19535
apalan60 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
143 changes: 143 additions & 0 deletions
143
...tests/src/test/java/org/apache/kafka/clients/admin/DescribeProducersWithBrokerIdTest.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,143 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one or more | ||
| * contributor license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright ownership. | ||
| * The ASF licenses this file to You under the Apache License, Version 2.0 | ||
| * (the "License"); you may not use this file except in compliance with | ||
| * the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package org.apache.kafka.clients.admin; | ||
|
|
||
| import org.apache.kafka.clients.producer.Producer; | ||
| import org.apache.kafka.clients.producer.ProducerRecord; | ||
| import org.apache.kafka.common.Node; | ||
| import org.apache.kafka.common.TopicPartition; | ||
| import org.apache.kafka.common.errors.NotLeaderOrFollowerException; | ||
| import org.apache.kafka.common.test.ClusterInstance; | ||
| import org.apache.kafka.common.test.api.ClusterTest; | ||
| import org.apache.kafka.common.test.api.ClusterTestDefaults; | ||
| import org.apache.kafka.test.TestUtils; | ||
|
|
||
| import org.junit.jupiter.api.BeforeEach; | ||
|
|
||
| import java.util.List; | ||
|
|
||
| import static org.junit.jupiter.api.Assertions.assertEquals; | ||
| import static org.junit.jupiter.api.Assertions.assertFalse; | ||
| import static org.junit.jupiter.api.Assertions.assertNotNull; | ||
|
|
||
|
|
||
| @ClusterTestDefaults( | ||
| brokers = 3 | ||
| ) | ||
| class DescribeProducersWithBrokerIdTest { | ||
| private static final String TOPIC_NAME = "test-topic"; | ||
| private static final int NUM_PARTITIONS = 1; | ||
| private static final short REPLICATION_FACTOR = 3; | ||
|
|
||
| private static final TopicPartition TOPIC_PARTITION = new TopicPartition(TOPIC_NAME, 0); | ||
|
|
||
| private final ClusterInstance clusterInstance; | ||
|
|
||
| public DescribeProducersWithBrokerIdTest(ClusterInstance clusterInstance) { | ||
| this.clusterInstance = clusterInstance; | ||
| } | ||
|
|
||
| private static void sendTestRecords(Producer<byte[], byte[]> producer) { | ||
| producer.send(new ProducerRecord<>(TOPIC_NAME, TOPIC_PARTITION.partition(), "key-0".getBytes(), "value-0".getBytes())); | ||
| producer.flush(); | ||
| } | ||
|
|
||
| @BeforeEach | ||
|
Owner
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. test |
||
| void setUp() throws InterruptedException { | ||
| clusterInstance.createTopic(TOPIC_NAME, NUM_PARTITIONS, REPLICATION_FACTOR); | ||
| } | ||
|
|
||
| private List<Integer> getReplicaBrokerIds(Admin admin) throws Exception { | ||
|
Owner
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. test review |
||
| var topicDescription = admin.describeTopics(List.of(TOPIC_PARTITION.topic())).allTopicNames().get().get(TOPIC_PARTITION.topic()); | ||
| return topicDescription.partitions().get(TOPIC_PARTITION.partition()).replicas().stream() | ||
| .map(Node::id) | ||
| .toList(); | ||
| } | ||
|
|
||
| private int getNonReplicaBrokerId(Admin admin) throws Exception { | ||
| var replicaBrokerIds = getReplicaBrokerIds(admin); | ||
| return clusterInstance.brokerIds().stream() | ||
| .filter(id -> !replicaBrokerIds.contains(id)) | ||
| .findFirst() | ||
| .orElseThrow(() -> new IllegalStateException("No non-replica broker found")); | ||
| } | ||
|
|
||
| private int getFollowerBrokerId(Admin admin) throws Exception { | ||
| var replicaBrokerIds = getReplicaBrokerIds(admin); | ||
| var leaderBrokerId = clusterInstance.getLeaderBrokerId(TOPIC_PARTITION); | ||
| return replicaBrokerIds.stream() | ||
| .filter(id -> id != leaderBrokerId) | ||
| .findFirst() | ||
| .orElseThrow(() -> new IllegalStateException("No follower found for partition " + TOPIC_PARTITION)); | ||
| } | ||
|
|
||
| @ClusterTest | ||
| void testDescribeProducersDefaultRoutesToLeader() throws Exception { | ||
| try (Producer<byte[], byte[]> producer = clusterInstance.producer(); | ||
| var admin = clusterInstance.admin()) { | ||
| sendTestRecords(producer); | ||
|
|
||
| var stateWithExplicitLeader = admin.describeProducers( | ||
| List.of(TOPIC_PARTITION), | ||
| new DescribeProducersOptions().brokerId(clusterInstance.getLeaderBrokerId(TOPIC_PARTITION)) | ||
| ).partitionResult(TOPIC_PARTITION).get(); | ||
|
|
||
| var stateWithDefaultRouting = admin.describeProducers( | ||
| List.of(TOPIC_PARTITION) | ||
| ).partitionResult(TOPIC_PARTITION).get(); | ||
|
|
||
| assertNotNull(stateWithDefaultRouting); | ||
| assertFalse(stateWithDefaultRouting.activeProducers().isEmpty()); | ||
| assertEquals(stateWithExplicitLeader.activeProducers(), stateWithDefaultRouting.activeProducers()); | ||
| } | ||
| } | ||
|
|
||
| @ClusterTest | ||
| void testDescribeProducersFromFollower() throws Exception { | ||
| try (Producer<byte[], byte[]> producer = clusterInstance.producer(); | ||
| var admin = clusterInstance.admin()) { | ||
| sendTestRecords(producer); | ||
|
|
||
| var followerState = admin.describeProducers( | ||
| List.of(TOPIC_PARTITION), | ||
| new DescribeProducersOptions().brokerId(getFollowerBrokerId(admin)) | ||
| ).partitionResult(TOPIC_PARTITION).get(); | ||
|
|
||
| var leaderState = admin.describeProducers( | ||
| List.of(TOPIC_PARTITION) | ||
| ).partitionResult(TOPIC_PARTITION).get(); | ||
|
|
||
| assertNotNull(followerState); | ||
| assertFalse(followerState.activeProducers().isEmpty()); | ||
| assertEquals(leaderState.activeProducers(), followerState.activeProducers()); | ||
| } | ||
| } | ||
|
|
||
| @ClusterTest(brokers = 4) | ||
| void testDescribeProducersWithInvalidBrokerId() throws Exception { | ||
| try (Producer<byte[], byte[]> producer = clusterInstance.producer(); | ||
| var admin = clusterInstance.admin()) { | ||
| sendTestRecords(producer); | ||
|
|
||
| TestUtils.assertFutureThrows(NotLeaderOrFollowerException.class, | ||
| admin.describeProducers( | ||
| List.of(TOPIC_PARTITION), | ||
| new DescribeProducersOptions().brokerId(getNonReplicaBrokerId(admin)) | ||
| ).partitionResult(TOPIC_PARTITION)); | ||
| } | ||
| } | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
t