Skip to content

[MINOR] Make nav zeppelin version to point ZEPPELIN_VERSION in _config.yml #997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
minahlee wants to merge 1 commit into from
Closed

[MINOR] Make nav zeppelin version to point ZEPPELIN_VERSION in _config.yml #997

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions docs/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,6 @@ See https://help.github.com/articles/using-jekyll-with-pages#installing-jekyll
## Bumping up version in a new release

* `ZEPPELIN_VERSION` and `BASE_PATH` property in _config.yml
* `Zeppelin <small>([VERSION])</small>` in _includes/themes/zeppelin/_navigation.html
should be updated


## Deploy to ASF svnpubsub infra (for committers only)
1. generate static website in `./_site`
Expand Down
2 changes: 1 addition & 1 deletion docs/_includes/themes/zeppelin/_navigation.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
<a class="navbar-brand" href="{{BASE_PATH}}">
<img src="/assets/themes/zeppelin/img/zeppelin_logo.png" width="50" alt="I'm zeppelin">
<span style="vertical-align:middle">Zeppelin</span>
<span style="vertical-align:baseline"><small>(0.6.0-SNAPSHOT)</small></span>
<span style="vertical-align:baseline"><small>{{site.ZEPPELIN_VERSION}}</small></span>
</a>
</div>
<nav class="navbar-collapse collapse" role="navigation">
Expand Down
3 changes: 2 additions & 1 deletion docs/assets/themes/zeppelin/css/style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -501,8 +501,9 @@ a.anchor {

.navbar-brand small {
font-size: 14px;
font-family: 'Helvetica Neue', Helvetica;
font-family: 'Open Sans', 'Helvetica Neue', Helvetica;
color: white;
vertical-align: bottom;
}

.navbar-collapse.collapse {
Expand Down