Skip to content

Conversation

@Leemoonsoo
Copy link
Member

What is this PR for?

Cache downloaded file from 'maven-download-plugin' to improve CI build speed and reduce build failure due to network issue.

What type of PR is it?

Improvement

Todos

  • - Cache '.m2/repository/.cache/maven-download-plugin' directory

What is the Jira issue?

https://issues.apache.org/jira/browse/ZEPPELIN-890

Questions:

  • Does the licenses files need update? no
  • Is there breaking changes for older versions? no
  • Does this needs documentation? no

@Leemoonsoo Leemoonsoo changed the title [ZEPPELIN-890] [ZEPPELIN-890] Cache downloaded file from 'maven-download-plugin' Jun 11, 2016
@prabhjyotsingh
Copy link
Contributor

@Leemoonsoo
Copy link
Member Author

@prabhjyotsingh Thanks for suggestion. Once travis caches '.m2/repository/.cache/maven-download-plugin' directory, 'maven-download-plugin' will not even try to download files from internet. So i think i'll be okay without increasing retry count.

@prabhjyotsingh
Copy link
Contributor

prabhjyotsingh commented Jun 11, 2016

Thank you for the explanation, I understand it now.
LGTM.

@Leemoonsoo
Copy link
Member Author

Merge if there're no further discussions

@prabhjyotsingh
Copy link
Contributor

Sure, I think we can merge this as a hotfix.

@khalidhuseynov
Copy link
Member

LGTM

@asfgit asfgit closed this in 7015a7c Jun 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants