[MINOR] Removed classloaderInterpreter on RemoteInterpreterServer #990
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Classloader in interpreter uses system classloader, thus there's no reason why interpreter is wrapped by Classloader
Member
Author
|
@Leemoonsoo Review this, please. |
Member
Author
|
I'll merge it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
Removed usage of ClassloaderInterpreter while RemoteInterpreter is being created.
What type of PR is it?
[Refactoring]
Todos
What is the Jira issue?
N/A
How should this be tested?
This PR should not change any user experience
Screenshots (if appropriate)
Questions:
Classloader in RemoteInterpreter uses system classloader, thus there's no reason why interpreter is wrapped by Classloader